From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 4/4] rpmsg: Add a removable attribute to the rpmsg device
Date: Tue, 15 Jun 2021 11:48:24 -0600 [thread overview]
Message-ID: <20210615174824.GC604521@p14s> (raw)
In-Reply-To: <20210604091406.15901-5-arnaud.pouliquen@foss.st.com>
On Fri, Jun 04, 2021 at 11:14:06AM +0200, Arnaud Pouliquen wrote:
> Adds a new attribute to the rpmsg device to expose in sysfs the
> the removability of an rpmsg device.
>
> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
> ---
> drivers/rpmsg/rpmsg_core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c
> index e5daee4f9373..b2543ef4a92f 100644
> --- a/drivers/rpmsg/rpmsg_core.c
> +++ b/drivers/rpmsg/rpmsg_core.c
> @@ -413,6 +413,7 @@ rpmsg_show_attr(src, src, "0x%x\n");
> rpmsg_show_attr(dst, dst, "0x%x\n");
> rpmsg_show_attr(announce, announce ? "true" : "false", "%s\n");
> rpmsg_string_attr(driver_override, driver_override);
> +rpmsg_show_attr(removable, us_removable ? "true" : "false", "%s\n");
>
> static ssize_t modalias_show(struct device *dev,
> struct device_attribute *attr, char *buf)
> @@ -435,6 +436,7 @@ static struct attribute *rpmsg_dev_attrs[] = {
> &dev_attr_src.attr,
> &dev_attr_announce.attr,
> &dev_attr_driver_override.attr,
> + &dev_attr_removable.attr,
And this patch shouldn't be needed if we move forward with my recommendation on
patch 3/4.
> NULL,
> };
> ATTRIBUTE_GROUPS(rpmsg_dev);
> --
> 2.17.1
>
prev parent reply other threads:[~2021-06-15 17:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 9:14 [PATCH 0/4] rpmsg: ctrl: Add ability to instantiate rpmsg device locally Arnaud Pouliquen
2021-06-04 9:14 ` [PATCH 1/4] rpmsg: ctrl: Introduce RPMSG_CREATE_DEV_IOCTL Arnaud Pouliquen
2021-06-15 17:53 ` Mathieu Poirier
2021-06-16 8:12 ` Arnaud POULIQUEN
2021-06-21 9:35 ` Arnaud POULIQUEN
2021-06-04 9:14 ` [PATCH 2/4] rpmsg: ctrl: Introduce RPMSG_RELEASE_DEV_IOCTL Arnaud Pouliquen
2021-06-15 17:38 ` Mathieu Poirier
2021-06-16 8:13 ` Arnaud POULIQUEN
2021-06-04 9:14 ` [PATCH 3/4] rpmsg: ctrl: Add check on rpmsg device removability from user space Arnaud Pouliquen
2021-06-15 17:46 ` Mathieu Poirier
2021-06-16 9:30 ` Arnaud POULIQUEN
2021-06-16 17:15 ` Mathieu Poirier
2021-06-17 8:02 ` Arnaud POULIQUEN
2021-06-17 16:55 ` Arnaud POULIQUEN
2021-06-17 16:56 ` Mathieu Poirier
2021-06-04 9:14 ` [PATCH 4/4] rpmsg: Add a removable attribute to the rpmsg device Arnaud Pouliquen
2021-06-15 17:48 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210615174824.GC604521@p14s \
--to=mathieu.poirier@linaro.org \
--cc=arnaud.pouliquen@foss.st.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).