From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5AD3C48BDF for ; Tue, 15 Jun 2021 20:39:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79EA0613B1 for ; Tue, 15 Jun 2021 20:39:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230352AbhFOUl5 (ORCPT ); Tue, 15 Jun 2021 16:41:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:44290 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229898AbhFOUl4 (ORCPT ); Tue, 15 Jun 2021 16:41:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2D9A7611C0; Tue, 15 Jun 2021 20:39:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623789591; bh=6+oMK7wCi10jdQ9Pp1G7b0FDyy4ILCTJVB7zAEjdXsw=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=dR8pjiWuDoDqOmvOvHj7Lwj2jKs6IKEcw078eWGs3AQs2GR4DHlnwzmuwbN5xYDRA SIustUX6eCQcd8Xto3LFXibZTjzAr5Qr+jfgI9fva+QiY4ESHqvNE6clT2/O0sFjgG nmTJLszr0U4qCgjfFe8hBuwIP2tqqdbVTL2F6tm1Cp2Ox3iOXXiEsymxz4aDGurLOI eCn5Q6khmLekWnluqBClw/gSP6y6LK9/ASsWD6ULDvuMyzy/QErUQ1zIp6sAmp8+u4 Qkx6lfGH/xJE7tkeyIkSnF6tBrCkeQhsWpCE6ozHyB6ibaTe5zrLr1nHs4tqqo1zpS /CTYJhOf9+Ptg== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 040C35C02A9; Tue, 15 Jun 2021 13:39:51 -0700 (PDT) Date: Tue, 15 Jun 2021 13:39:51 -0700 From: "Paul E. McKenney" To: Marco Elver Cc: Mark Rutland , boqun.feng@gmail.com, will@kernel.org, glider@google.com, dvyukov@google.com, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/7] kcsan: Introduce CONFIG_KCSAN_PERMISSIVE Message-ID: <20210615203951.GU4397@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20210607125653.1388091-1-elver@google.com> <20210609123810.GA37375@C02TD0UTHF1T.local> <20210615181946.GA2727668@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 15, 2021 at 08:51:18PM +0200, Marco Elver wrote: > On Tue, Jun 15, 2021 at 11:19AM -0700, Paul E. McKenney wrote: > [...] > > Queued and pushed for v5.15, thank you both! > > > > I also queued the following patch making use of CONFIG_KCSAN_STRICT, and I > > figured that I should run it past you guys to make check my understanding. > > > > Thoughts? > > You still need CONFIG_KCSAN_INTERRUPT_WATCHER=y, but otherwise looks > good. I knew I was missing something... :-/ > I thought I'd leave that out for now, but now thinking about it, we > might as well imply interruptible watchers. If you agree, feel free to > queue the below patch ahead of yours. That works for me! I have queued the patch below and rebased it to precede my change to the torture-test infrastructure. Thanx, Paul > Thanks, > -- Marco > > ------ >8 ------ > > From: Marco Elver > Date: Tue, 15 Jun 2021 20:39:38 +0200 > Subject: [PATCH] kcsan: Make strict mode imply interruptible watchers > > If CONFIG_KCSAN_STRICT=y, select CONFIG_KCSAN_INTERRUPT_WATCHER as well. > > With interruptible watchers, we'll also report same-CPU data races; if > we requested strict mode, we might as well show these, too. > > Suggested-by: Paul E. McKenney > Signed-off-by: Marco Elver > --- > lib/Kconfig.kcsan | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/Kconfig.kcsan b/lib/Kconfig.kcsan > index 26f03c754d39..e0a93ffdef30 100644 > --- a/lib/Kconfig.kcsan > +++ b/lib/Kconfig.kcsan > @@ -150,7 +150,8 @@ config KCSAN_SKIP_WATCH_RANDOMIZE > KCSAN_WATCH_SKIP. > > config KCSAN_INTERRUPT_WATCHER > - bool "Interruptible watchers" > + bool "Interruptible watchers" if !KCSAN_STRICT > + default KCSAN_STRICT > help > If enabled, a task that set up a watchpoint may be interrupted while > delayed. This option will allow KCSAN to detect races between > -- > 2.32.0.272.g935e593368-goog >