linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Aswath Govindraju <a-govindraju@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>, Suman Anna <s-anna@ti.com>,
	Lokesh Vutla <lokeshvutla@ti.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/3] arm64: dts: ti: k3-am64-main: Update TF-A's maximum size and node name
Date: Tue, 15 Jun 2021 19:19:20 -0500	[thread overview]
Message-ID: <20210616001920.m7a4v5nhkfowd4i3@huntsman> (raw)
In-Reply-To: <20210615174325.22853-2-a-govindraju@ti.com>

On 23:13-20210615, Aswath Govindraju wrote:
> The maximum size of TF-A 2.5 has been increased to 0x1c000 [1]. Therefore,
> update this accordingly in the device tree node.
> 
> Also, update the node name to "tfa-sram".

> [1] - https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/commit/?id=2fb5312f61a7de8b7a70e1639199c4f14a10b6f9
> 
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> Reviewed-by: Suman Anna <s-anna@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> index dec54243f454..693fe24e7f7a 100644
> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> @@ -24,8 +24,8 @@
>  		#size-cells = <1>;
>  		ranges = <0x0 0x00 0x70000000 0x200000>;
>  
> -		atf-sram@0 {
> -			reg = <0x0 0x1a000>;
> +		tfa-sram@0 {
> +			reg = <0x0 0x1c000>;

Thanks for catching this, but, I think tying things down tightly to
exact current size of TF-A is going to be tricky thing for us to
sustain. I suggest we make this 128K to account for future expansions
that are already known to be necessary for TF-A rather than another
piecemeal breaking change in the future.

>  		};
>  	};
>  
> -- 
> 2.17.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

  reply	other threads:[~2021-06-16  0:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15 17:43 [PATCH v4 0/3] AM64: Update the locations of various elements in SRAM Aswath Govindraju
2021-06-15 17:43 ` [PATCH v4 1/3] arm64: dts: ti: k3-am64-main: Update TF-A's maximum size and node name Aswath Govindraju
2021-06-16  0:19   ` Nishanth Menon [this message]
2021-06-15 17:43 ` [PATCH v4 2/3] arm64: dts: ti: k3-am64-main: Reserve OCMRAM for DMSC-lite and secure proxy communication Aswath Govindraju
2021-06-15 18:48   ` Suman Anna
2021-06-15 17:43 ` [PATCH v4 3/3] arm64: dts: ti: k3-am64-main: Update the location of TF-A Aswath Govindraju
2021-06-15 18:48   ` Suman Anna
2021-06-16  0:20   ` Nishanth Menon
2021-06-16  8:43     ` Aswath Govindraju
2021-06-15 18:49 ` [PATCH v4 0/3] AM64: Update the locations of various elements in SRAM Suman Anna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210616001920.m7a4v5nhkfowd4i3@huntsman \
    --to=nm@ti.com \
    --cc=a-govindraju@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@ti.com \
    --cc=kristo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=s-anna@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).