linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] drivers: ti: remove redundant error message in adpll.c
@ 2021-06-16  3:48 Yu Jiahua
  2021-06-28  2:56 ` Stephen Boyd
  0 siblings, 1 reply; 2+ messages in thread
From: Yu Jiahua @ 2021-06-16  3:48 UTC (permalink / raw)
  To: kristo, mturquette, sboyd; +Cc: linux-omap, linux-clk, linux-kernel, Yu Jiahua

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Yu Jiahua <yujiahua1@huawei.com>
---
 drivers/clk/ti/adpll.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/clk/ti/adpll.c b/drivers/clk/ti/adpll.c
index bb2f2836dab2..b341cd990be7 100644
--- a/drivers/clk/ti/adpll.c
+++ b/drivers/clk/ti/adpll.c
@@ -896,11 +896,8 @@ static int ti_adpll_probe(struct platform_device *pdev)
 	d->pa = res->start;
 
 	d->iobase = devm_ioremap_resource(dev, res);
-	if (IS_ERR(d->iobase)) {
-		dev_err(dev, "could not get IO base: %li\n",
-			PTR_ERR(d->iobase));
+	if (IS_ERR(d->iobase))
 		return PTR_ERR(d->iobase);
-	}
 
 	err = ti_adpll_init_registers(d);
 	if (err)
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] drivers: ti: remove redundant error message in adpll.c
  2021-06-16  3:48 [PATCH -next] drivers: ti: remove redundant error message in adpll.c Yu Jiahua
@ 2021-06-28  2:56 ` Stephen Boyd
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2021-06-28  2:56 UTC (permalink / raw)
  To: Yu Jiahua, kristo, mturquette
  Cc: linux-omap, linux-clk, linux-kernel, Yu Jiahua

Quoting Yu Jiahua (2021-06-15 20:48:26)
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Signed-off-by: Yu Jiahua <yujiahua1@huawei.com>
> ---

Applied to clk-next

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-28  2:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16  3:48 [PATCH -next] drivers: ti: remove redundant error message in adpll.c Yu Jiahua
2021-06-28  2:56 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).