* [PATCH bpf] samples/bpf: Fix Segmentation fault for xdp_redirect command
@ 2021-06-16 4:23 Wang Hai
2021-06-18 18:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Wang Hai @ 2021-06-16 4:23 UTC (permalink / raw)
To: davem, kuba, ast, daniel, hawk, john.fastabend, andrii, kafai,
songliubraving, yhs, kpsingh
Cc: bpf, netdev, linux-kernel
A Segmentation fault error is caused when the following command
is executed.
$ sudo ./samples/bpf/xdp_redirect lo
Segmentation fault
This command is missing a device <IFNAME|IFINDEX> as an argument, resulting
in out-of-bounds access from argv.
If the number of devices for the xdp_redirect parameter is not 2,
we should report an error and exit.
Fixes: 24251c264798 ("samples/bpf: add option for native and skb mode for redirect apps")
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
samples/bpf/xdp_redirect_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/samples/bpf/xdp_redirect_user.c b/samples/bpf/xdp_redirect_user.c
index c903f1ccc15e..93854e135134 100644
--- a/samples/bpf/xdp_redirect_user.c
+++ b/samples/bpf/xdp_redirect_user.c
@@ -130,7 +130,7 @@ int main(int argc, char **argv)
if (!(xdp_flags & XDP_FLAGS_SKB_MODE))
xdp_flags |= XDP_FLAGS_DRV_MODE;
- if (optind == argc) {
+ if (optind + 2 != argc) {
printf("usage: %s <IFNAME|IFINDEX>_IN <IFNAME|IFINDEX>_OUT\n", argv[0]);
return 1;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf] samples/bpf: Fix Segmentation fault for xdp_redirect command
2021-06-16 4:23 [PATCH bpf] samples/bpf: Fix Segmentation fault for xdp_redirect command Wang Hai
@ 2021-06-18 18:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-18 18:20 UTC (permalink / raw)
To: Wang Hai
Cc: davem, kuba, ast, daniel, hawk, john.fastabend, andrii, kafai,
songliubraving, yhs, kpsingh, bpf, netdev, linux-kernel
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
On Wed, 16 Jun 2021 12:23:24 +0800 you wrote:
> A Segmentation fault error is caused when the following command
> is executed.
>
> $ sudo ./samples/bpf/xdp_redirect lo
> Segmentation fault
>
> This command is missing a device <IFNAME|IFINDEX> as an argument, resulting
> in out-of-bounds access from argv.
>
> [...]
Here is the summary with links:
- [bpf] samples/bpf: Fix Segmentation fault for xdp_redirect command
https://git.kernel.org/bpf/bpf-next/c/85102ba58b41
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-18 18:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 4:23 [PATCH bpf] samples/bpf: Fix Segmentation fault for xdp_redirect command Wang Hai
2021-06-18 18:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).