From: Viresh Kumar <viresh.kumar@linaro.org>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: "Viresh Kumar )" <vireshk@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"andrew-sh . cheng" <andrew-sh.cheng@mediatek.com>
Subject: Re: [PATCH] opp: of: Allow lazy-linking of required-opps to non genpd
Date: Wed, 16 Jun 2021 12:39:48 +0530 [thread overview]
Message-ID: <20210616070948.2oaxc54p5uxknw36@vireshk-i7> (raw)
In-Reply-To: <CAJMQK-h2R5s6rWWjr1YHO1jqZdtBkT3LYjcVg4QNMUuXJSiMTg@mail.gmail.com>
On 16-06-21, 14:25, Hsin-Yi Wang wrote:
> When cpufreq changes, the (cpufreq based) passive governor will
> calculate a target devfreq based on that, and the device governor
> (mt8183-cci-devfreq) will change the actual opp of the device.
>
> The required-opp is set in the cpufreq table:
>
> cpufreq_opp_table: opp_table0 {
> compatible = "operating-points-v2";
> opp-shared;
> ...
> opp0_01 {
> opp-hz = /bits/ 64 <910000000>;
> opp-microvolt = <687500>;
> required-opps = <&opp2_01>;
> };
> ...
> };
>
> devfreq_opp_table: opp_table2 {
> compatible = "operating-points-v2";
> opp-shared;
> ...
> opp2_01: opp-338000000 {
> opp-hz = /bits/ 64 <338000000>;
> opp-microvolt = <687500>;
> };
> ...
> };
Ah, you aren't using dev_pm_opp_set_opp() or dev_pm_opp_set_rate()
interfaces.
Looks okay then.
--
viresh
next prev parent reply other threads:[~2021-06-16 7:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 5:33 [PATCH] opp: of: Allow lazy-linking of required-opps to non genpd Hsin-Yi Wang
2021-06-16 5:58 ` Viresh Kumar
2021-06-16 6:25 ` Hsin-Yi Wang
2021-06-16 7:09 ` Viresh Kumar [this message]
2021-06-16 7:55 ` Viresh Kumar
2021-06-16 8:47 ` Chanwoo Choi
2021-06-16 9:09 ` Viresh Kumar
2021-06-16 9:20 ` Hsin-Yi Wang
2021-06-17 1:13 ` Chanwoo Choi
2021-06-17 3:33 ` Viresh Kumar
2021-06-17 4:09 ` Chanwoo Choi
2021-06-17 4:00 ` Viresh Kumar
2021-06-17 4:27 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210616070948.2oaxc54p5uxknw36@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=andrew-sh.cheng@mediatek.com \
--cc=cw00.choi@samsung.com \
--cc=hsinyi@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=sboyd@kernel.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).