From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Oliver Hartkopp <socketcan@hartkopp.net>
Subject: Re: [PATCH v2 2/2] can: netlink: add interface for CAN-FD Transmitter Delay Compensation (TDC)
Date: Wed, 16 Jun 2021 11:46:33 +0200 [thread overview]
Message-ID: <20210616094633.fwg6rsyxyvm2zc6d@pengutronix.de> (raw)
In-Reply-To: <20210603151550.140727-3-mailhol.vincent@wanadoo.fr>
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
On 04.06.2021 00:15:50, Vincent Mailhol wrote:
[...]
> +static size_t can_tdc_get_size(const struct net_device *dev)
> +{
> + struct can_priv *priv = netdev_priv(dev);
> + size_t size;
> +
> + if (!priv->tdc_const)
> + return 0;
> +
> + size = nla_total_size(0); /* nest IFLA_CAN_TDC */
> + size += nla_total_size(sizeof(u32)); /* IFLA_CAN_TDCV_MAX */
> + size += nla_total_size(sizeof(u32)); /* IFLA_CAN_TDCO_MAX */
> + size += nla_total_size(sizeof(u32)); /* IFLA_CAN_TDCF_MAX */
> +
> + if (priv->tdc.tdco) {
Naively I'd say, iff the device has tdc_const give the user space the
tdc parameters, regardless if some value is 0 or not.
What do you think?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-06-16 9:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 15:15 [PATCH v2 0/2] add the netlink interface for CAN-FD Transmitter Delay Compensation (TDC) Vincent Mailhol
2021-06-03 15:15 ` [PATCH v2 1/2] can: netlink: remove redundant check in can_validate() Vincent Mailhol
2021-06-03 15:15 ` [PATCH v2 2/2] can: netlink: add interface for CAN-FD Transmitter Delay Compensation (TDC) Vincent Mailhol
2021-06-16 9:46 ` Marc Kleine-Budde [this message]
2021-06-16 13:53 ` Vincent MAILHOL
2021-06-16 14:29 ` Marc Kleine-Budde
2021-06-16 14:43 ` Vincent MAILHOL
2021-06-16 14:46 ` Marc Kleine-Budde
2021-06-16 15:44 ` Vincent MAILHOL
2021-06-17 11:38 ` Marc Kleine-Budde
2021-06-18 9:34 ` Marc Kleine-Budde
2021-06-18 10:23 ` Vincent MAILHOL
2021-06-18 11:17 ` Vincent MAILHOL
2021-06-18 12:44 ` CAN-FD Transmitter Delay Compensation (TDC) on mcp2518fd Marc Kleine-Budde
2021-06-18 14:27 ` Vincent MAILHOL
2021-06-18 15:55 ` Stefan Mätje
2021-06-19 12:34 ` Vincent MAILHOL
2021-06-21 18:42 ` Stefan Mätje
2021-06-21 23:52 ` Vincent MAILHOL
2021-06-22 0:04 ` Vincent MAILHOL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210616094633.fwg6rsyxyvm2zc6d@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).