linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacopo Mondi <jacopo+renesas@jmondi.org>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	kieran.bingham+renesas@ideasonboard.com,
	laurent.pinchart+renesas@ideasonboard.com,
	niklas.soderlund+renesas@ragnatech.se, geert@linux-m68k.org
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: [PATCH v5 14/15] media: i2c: rdacm20: Check return values
Date: Wed, 16 Jun 2021 14:46:15 +0200	[thread overview]
Message-ID: <20210616124616.49249-15-jacopo+renesas@jmondi.org> (raw)
In-Reply-To: <20210616124616.49249-1-jacopo+renesas@jmondi.org>

The camera module initialization routine does not check the return
value of a few functions. Fix that.

Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/media/i2c/rdacm20.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c
index f1819bfa165d..e6fed86a3281 100644
--- a/drivers/media/i2c/rdacm20.c
+++ b/drivers/media/i2c/rdacm20.c
@@ -466,11 +466,16 @@ static int rdacm20_initialize(struct rdacm20_device *dev)
 	 *  Ensure that we have a good link configuration before attempting to
 	 *  identify the device.
 	 */
-	max9271_configure_i2c(&dev->serializer, MAX9271_I2CSLVSH_469NS_234NS |
-						MAX9271_I2CSLVTO_1024US |
-						MAX9271_I2CMSTBT_105KBPS);
+	ret = max9271_configure_i2c(&dev->serializer,
+				    MAX9271_I2CSLVSH_469NS_234NS |
+				    MAX9271_I2CSLVTO_1024US |
+				    MAX9271_I2CMSTBT_105KBPS);
+	if (ret)
+		return ret;
 
-	max9271_configure_gmsl_link(&dev->serializer);
+	ret = max9271_configure_gmsl_link(&dev->serializer);
+	if (ret)
+		return ret;
 
 	ret = max9271_verify_id(&dev->serializer);
 	if (ret < 0)
-- 
2.31.1


  parent reply	other threads:[~2021-06-16 12:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16 12:46 [PATCH v5 00/15] media: gmsl: Reliability improvements Jacopo Mondi
2021-06-16 12:46 ` [PATCH v5 01/15] media: i2c: max9286: Adjust parameters indent Jacopo Mondi
2021-06-16 12:46 ` [PATCH v5 02/15] media: i2c: max9286: Rename reverse_channel_mv Jacopo Mondi
2021-06-16 12:46 ` [PATCH v5 03/15] media: i2c: max9286: Cache channel amplitude Jacopo Mondi
2021-06-16 12:46 ` [PATCH v5 04/15] media: i2c: max9286: Define high " Jacopo Mondi
2021-06-16 12:46 ` [PATCH v5 05/15] media: i2c: max9286: Rework comments in .bound() Jacopo Mondi
2021-06-16 12:46 ` [PATCH v5 06/15] media: i2c: max9271: Check max9271_write() return Jacopo Mondi
2021-06-16 12:46 ` [PATCH v5 07/15] media: i2c: max9271: Introduce wake_up() function Jacopo Mondi
2021-06-16 12:46 ` [PATCH v5 08/15] media: i2c: rdacm21: Add delay after OV490 reset Jacopo Mondi
2021-06-16 12:46 ` [PATCH v5 09/15] media: i2c: rdacm21: Fix OV10640 powerup Jacopo Mondi
2021-06-16 12:46 ` [PATCH v5 10/15] media: i2c: rdacm21: Power up OV10640 before OV490 Jacopo Mondi
2021-06-16 23:47   ` Kieran Bingham
2021-06-16 12:46 ` [PATCH v5 11/15] media: i2c: rdacm20: Enable noise immunity Jacopo Mondi
2021-06-16 12:46 ` [PATCH v5 12/15] media: i2c: rdacm20: Embed 'serializer' field Jacopo Mondi
2021-06-17  0:14   ` Laurent Pinchart
2021-06-17  6:18     ` Hans Verkuil
2021-06-17  7:42       ` Jacopo Mondi
2021-06-17  8:12         ` Hans Verkuil
2021-06-17  8:20           ` Jacopo Mondi
2021-06-16 12:46 ` [PATCH v5 13/15] media: i2c: rdacm20: Report camera module name Jacopo Mondi
2021-06-16 12:46 ` Jacopo Mondi [this message]
2021-06-16 12:46 ` [PATCH v5 15/15] media: i2c: rdacm20: Re-work ov10635 reset Jacopo Mondi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210616124616.49249-15-jacopo+renesas@jmondi.org \
    --to=jacopo+renesas@jmondi.org \
    --cc=geert@linux-m68k.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).