* [PATCH][next] scsi: elx: libefc: Fix less than zero comparison of a unsigned int
@ 2021-06-16 17:04 Colin King
2021-06-19 2:28 ` Martin K. Petersen
2021-06-19 15:46 ` James Smart
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2021-06-16 17:04 UTC (permalink / raw)
To: James Smart, Ram Vegesna, James E . J . Bottomley,
Martin K . Petersen, Hannes Reinecke, linux-scsi, target-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The comparison of the u32 variable rc to less than zero always
false because it is unsigned. Fix this by making it an int.
Addresses-Coverity: ("Unsigned compared against 0")
Fixes: 202bfdffae27 ("scsi: elx: libefc: FC node ELS and state handling")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/elx/libefc/efc_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/elx/libefc/efc_device.c b/drivers/scsi/elx/libefc/efc_device.c
index 31a688bce6e9..725ca2a23fb2 100644
--- a/drivers/scsi/elx/libefc/efc_device.c
+++ b/drivers/scsi/elx/libefc/efc_device.c
@@ -15,7 +15,7 @@
void
efc_d_send_prli_rsp(struct efc_node *node, u16 ox_id)
{
- u32 rc = EFC_SCSI_CALL_COMPLETE;
+ int rc = EFC_SCSI_CALL_COMPLETE;
struct efc *efc = node->efc;
node->ls_acc_oxid = ox_id;
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] scsi: elx: libefc: Fix less than zero comparison of a unsigned int
2021-06-16 17:04 [PATCH][next] scsi: elx: libefc: Fix less than zero comparison of a unsigned int Colin King
@ 2021-06-19 2:28 ` Martin K. Petersen
2021-06-19 15:46 ` James Smart
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-06-19 2:28 UTC (permalink / raw)
To: Colin King
Cc: James Smart, Ram Vegesna, James E . J . Bottomley,
Martin K . Petersen, Hannes Reinecke, linux-scsi, target-devel,
kernel-janitors, linux-kernel
Colin,
> The comparison of the u32 variable rc to less than zero always false
> because it is unsigned. Fix this by making it an int.
Applied to 5.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] scsi: elx: libefc: Fix less than zero comparison of a unsigned int
2021-06-16 17:04 [PATCH][next] scsi: elx: libefc: Fix less than zero comparison of a unsigned int Colin King
2021-06-19 2:28 ` Martin K. Petersen
@ 2021-06-19 15:46 ` James Smart
1 sibling, 0 replies; 3+ messages in thread
From: James Smart @ 2021-06-19 15:46 UTC (permalink / raw)
To: Colin King, James Smart, Ram Vegesna, James E . J . Bottomley,
Martin K . Petersen, Hannes Reinecke, linux-scsi, target-devel
Cc: kernel-janitors, linux-kernel
On 6/16/2021 10:04 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The comparison of the u32 variable rc to less than zero always
> false because it is unsigned. Fix this by making it an int.
>
> Addresses-Coverity: ("Unsigned compared against 0")
> Fixes: 202bfdffae27 ("scsi: elx: libefc: FC node ELS and state handling")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/scsi/elx/libefc/efc_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks!
Reviewed-by: James Smart <jsmart2021@gmail.com>
-- james
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-19 15:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 17:04 [PATCH][next] scsi: elx: libefc: Fix less than zero comparison of a unsigned int Colin King
2021-06-19 2:28 ` Martin K. Petersen
2021-06-19 15:46 ` James Smart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).