* [RFC net-next] net/sched: cls_flower: fix resetting of ether proto mask
@ 2021-06-16 17:09 Vadym Kochan
0 siblings, 0 replies; only message in thread
From: Vadym Kochan @ 2021-06-16 17:09 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Jamal Hadi Salim, Cong Wang,
Andrew Lunn, Vladimir Oltean
Cc: Vadym Kochan, netdev, linux-kernel, Boris Sukholitko
In case of matching 'protocol' the rule does not work:
tc filter add dev $DEV ingress prio 1 protocol $PROTO flower skip_sw action drop
so clear the ether proto mask only for CVLAN case.
Fixes: 0dca2c7404a9 ("net/sched: cls_flower: Remove match on n_proto")
CC: Boris Sukholitko <boris.sukholitko@broadcom.com>
Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>
---
I am still in testing process of the patch but reverting of
referrenced commit solved the issue.
The issue was observed on Marvel Prestera ACL patches
with HW offloaded TC rules.
net/sched/cls_flower.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c
index 2e704c7a105a..997ca0549c45 100644
--- a/net/sched/cls_flower.c
+++ b/net/sched/cls_flower.c
@@ -1534,10 +1534,13 @@ static int fl_set_key(struct net *net, struct nlattr **tb,
mask->basic.n_proto = cpu_to_be16(0);
} else {
key->basic.n_proto = ethertype;
+ mask->basic.n_proto = cpu_to_be16(~0);
+
}
}
} else {
key->basic.n_proto = ethertype;
+ mask->basic.n_proto = cpu_to_be16(~0);
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-16 17:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 17:09 [RFC net-next] net/sched: cls_flower: fix resetting of ether proto mask Vadym Kochan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).