From: Pu Lehui <pulehui@huawei.com>
To: <keescook@chromium.org>, <anton@enomsg.org>, <ccross@android.com>,
<tony.luck@intel.com>
Cc: <linux-kernel@vger.kernel.org>, <pulehui@huawei.com>,
<zhangjinhao2@huawei.com>
Subject: [PATCH -next] pstore/blk: Fix return value check in pstore_blk_init()
Date: Thu, 17 Jun 2021 08:54:24 +0800 [thread overview]
Message-ID: <20210617005424.182305-1-pulehui@huawei.com> (raw)
Fix the return value check which testing the wrong variable
in pstore_blk_init().
Signed-off-by: Pu Lehui <pulehui@huawei.com>
---
fs/pstore/blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/pstore/blk.c b/fs/pstore/blk.c
index ccfb11ee4d50..d5e22e6209a6 100644
--- a/fs/pstore/blk.c
+++ b/fs/pstore/blk.c
@@ -287,7 +287,7 @@ static int __init pstore_blk_init(void)
struct pstore_device_info *best_effort_dev;
best_effort_dev = kzalloc(sizeof(*best_effort_dev), GFP_KERNEL);
- if (!best_effort) {
+ if (!best_effort_dev) {
ret = -ENOMEM;
goto unlock;
}
--
2.17.1
next reply other threads:[~2021-06-17 0:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 0:54 Pu Lehui [this message]
2021-06-17 3:19 ` [PATCH -next] pstore/blk: Fix return value check in pstore_blk_init() Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617005424.182305-1-pulehui@huawei.com \
--to=pulehui@huawei.com \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=zhangjinhao2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).