From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03B92C2B9F4 for ; Thu, 17 Jun 2021 04:00:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D280E61026 for ; Thu, 17 Jun 2021 04:00:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229827AbhFQECi (ORCPT ); Thu, 17 Jun 2021 00:02:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229693AbhFQECg (ORCPT ); Thu, 17 Jun 2021 00:02:36 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C28DCC061574 for ; Wed, 16 Jun 2021 21:00:29 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id x21-20020a17090aa395b029016e25313bfcso3058266pjp.2 for ; Wed, 16 Jun 2021 21:00:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pC2Nbi4igIwZvfic20raTQXRqc481qbOBEUTVrlffcM=; b=W/Iz1s1iFfzN5NvkND/sJwgBiBkIIUdYhZYEzcC69P6VQr3inUKzT+ewHPDavXOzNO gZ31rQmoZCHRo6c2NQ7VfiginGJ7AUWhmtRgUnqa0x9cBbcszsTueHaYbpCjB6lLpVIZ D2KqiGtwlGPX4/es4yI89OKiOePddqF2eV9F9Wh+mbArFJKYELXwj69oSh02zy/CwfuG yxnXCk7kpy28qm41eFsC+lXhmF2JgHtndb4UsQV24wb05SNfxCLRjK2Meu3oOPJ5Ex04 JpMS078ZqB1H6bwcCtAPHVb9EuFp1QmZ+a8XHyEd2q4VpGyTAlNqTVjvb2DFDgcquz1y 0DjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pC2Nbi4igIwZvfic20raTQXRqc481qbOBEUTVrlffcM=; b=P1V2v8T3q2hw4cVbfQ/3Rilvcoi6rsxhJLMzdONbBY7cfeEGpW8NTdkMUUyb4mQ9hF 4lSvUaPGhXH2Sq1s8MMoxN/Pm6Ro/fNGpnPr0oT9smewCp3GKlt605NoDOqleKWkrmkk c+gsw2Uh2dBOE7SBu/Z0bl66alQlFKcL7gqBQ2w8hI6LM6/W7LUgy1gB1Ud9t7/Pe62r nOTHiYOnxmwkpe4moqNJgg3Z3QJWSjFRuzYl3RAo9Wmr6GEc8Dqk0fvzAa7toelPDOUU aggRH451kniuzWxmcw8eQ3wp22706jOvH0h3nY4kD7eo+otGFt7ls3jk5BN+c5ntdlm6 gRlw== X-Gm-Message-State: AOAM530qiKswYCy8kVn+TDfWxacvjEfCn42rmONJIgDGLkJO6lK9vAIl Qql2wp7Z9uubdArC/1rgGTQ+8g== X-Google-Smtp-Source: ABdhPJyDv7ubI5q+IKKJfE9KSESdn7Qn3OCPz3FLjbADh/Q4cQNBLHiksqUAZ4ofi1gqIRGVprwt/Q== X-Received: by 2002:a17:902:bd09:b029:ec:7e58:a54a with SMTP id p9-20020a170902bd09b02900ec7e58a54amr2751421pls.62.1623902429381; Wed, 16 Jun 2021 21:00:29 -0700 (PDT) Received: from localhost ([136.185.134.182]) by smtp.gmail.com with ESMTPSA id 20sm3495193pfi.170.2021.06.16.21.00.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Jun 2021 21:00:28 -0700 (PDT) Date: Thu, 17 Jun 2021 09:30:27 +0530 From: Viresh Kumar To: Chanwoo Choi Cc: Hsin-Yi Wang , "Viresh Kumar )" , Nishanth Menon , Stephen Boyd , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "andrew-sh . cheng" Subject: Re: [PATCH] opp: of: Allow lazy-linking of required-opps to non genpd Message-ID: <20210617040027.vtqlhxqq7cwzeygg@vireshk-i7> References: <20210616053335.4181780-1-hsinyi@chromium.org> <20210616075548.ghp3lmjf4y6pyxoy@vireshk-i7> <20210616090945.sn337tftdcp7y7y6@vireshk-i7> <742b2623-e8ff-db1f-9168-bdbde98110dd@samsung.com> <20210617033351.44pxdpjicm62byuh@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17-06-21, 13:09, Chanwoo Choi wrote: > On 6/17/21 12:33 PM, Viresh Kumar wrote: > > On 17-06-21, 10:13, Chanwoo Choi wrote: > >> The devfreq driver(exynos-bus.c) has used the dev_pm_opp_set_rate() > >> and used the passive governor without the required-opp property. > > > > Which is fine. > > > >> I have a plan to use the required-opp property > >> between devfreq drivers (exynos-bus.c) with dev_pm_opp_set_rate(). > >> > >> I'll support them on later if this approach doesn't break the any > >> rule of required-opp property. > > > > You will be required to make some changes in core for that I am > > afraid. It won't work automatically. > > Do you think that better to use clk_enable/regulator_enable directly > instead of dev_pm_opp_set_rate() for using required-opp property? No. All I am saying is that the OPP core won't work for your use case today and may need some updates. -- viresh