linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] genirq/cpuhotplug: Bump debugging information print down to KERN_DEBUG
@ 2021-06-17  7:31 Lee Jones
  2021-08-10 14:21 ` Thomas Gleixner
  0 siblings, 1 reply; 5+ messages in thread
From: Lee Jones @ 2021-06-17  7:31 UTC (permalink / raw)
  To: lee.jones; +Cc: linux-arm-kernel, linux-kernel, Thomas Gleixner

This sort of information is only generally useful when debugging.

No need to have these sprinkled through the kernel log otherwise.

Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 kernel/irq/cpuhotplug.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/irq/cpuhotplug.c b/kernel/irq/cpuhotplug.c
index 02236b13b3599..cf8d4f75632e8 100644
--- a/kernel/irq/cpuhotplug.c
+++ b/kernel/irq/cpuhotplug.c
@@ -42,7 +42,7 @@ static inline bool irq_needs_fixup(struct irq_data *d)
 		 * If this happens then there was a missed IRQ fixup at some
 		 * point. Warn about it and enforce fixup.
 		 */
-		pr_warn("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n",
+		pr_debug("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n",
 			cpumask_pr_args(m), d->irq, cpu);
 		return true;
 	}
@@ -166,7 +166,7 @@ void irq_migrate_all_off_this_cpu(void)
 		raw_spin_unlock(&desc->lock);
 
 		if (affinity_broken) {
-			pr_warn_ratelimited("IRQ %u: no longer affine to CPU%u\n",
+			pr_debug_ratelimited("IRQ %u: no longer affine to CPU%u\n",
 					    irq, smp_processor_id());
 		}
 	}
-- 
2.32.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] genirq/cpuhotplug: Bump debugging information print down to KERN_DEBUG
  2021-06-17  7:31 [PATCH 1/1] genirq/cpuhotplug: Bump debugging information print down to KERN_DEBUG Lee Jones
@ 2021-08-10 14:21 ` Thomas Gleixner
  2021-08-11  7:57   ` Lee Jones
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Gleixner @ 2021-08-10 14:21 UTC (permalink / raw)
  To: Lee Jones, lee.jones
  Cc: linux-arm-kernel, linux-kernel, Ming Lei, Hannes Reinecke

On Thu, Jun 17 2021 at 08:31, Lee Jones wrote:
> This sort of information is only generally useful when debugging.
>
> No need to have these sprinkled through the kernel log otherwise.

Yes and no. 

> Cc: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  kernel/irq/cpuhotplug.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/irq/cpuhotplug.c b/kernel/irq/cpuhotplug.c
> index 02236b13b3599..cf8d4f75632e8 100644
> --- a/kernel/irq/cpuhotplug.c
> +++ b/kernel/irq/cpuhotplug.c
> @@ -42,7 +42,7 @@ static inline bool irq_needs_fixup(struct irq_data *d)
>  		 * If this happens then there was a missed IRQ fixup at some
>  		 * point. Warn about it and enforce fixup.
>  		 */
> -		pr_warn("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n",

This one is clearly a warning as this should not happen. See the
comments around that.

> +		pr_debug("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n",
>  			cpumask_pr_args(m), d->irq, cpu);
>  		return true;
>  	}
> @@ -166,7 +166,7 @@ void irq_migrate_all_off_this_cpu(void)
>  		raw_spin_unlock(&desc->lock);
>  
>  		if (affinity_broken) {
> -			pr_warn_ratelimited("IRQ %u: no longer affine to CPU%u\n",
> +			pr_debug_ratelimited("IRQ %u: no longer affine to CPU%u\n",
>  					    irq, smp_processor_id());

Maybe, but distro people might have opinions on that.

Thanks,

        tglx

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] genirq/cpuhotplug: Bump debugging information print down to KERN_DEBUG
  2021-08-10 14:21 ` Thomas Gleixner
@ 2021-08-11  7:57   ` Lee Jones
  2021-08-11 12:08     ` Thomas Gleixner
  0 siblings, 1 reply; 5+ messages in thread
From: Lee Jones @ 2021-08-11  7:57 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: linux-arm-kernel, linux-kernel, Ming Lei, Hannes Reinecke

On Tue, 10 Aug 2021, Thomas Gleixner wrote:

> On Thu, Jun 17 2021 at 08:31, Lee Jones wrote:
> > This sort of information is only generally useful when debugging.
> >
> > No need to have these sprinkled through the kernel log otherwise.
> 
> Yes and no. 
> 
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >  kernel/irq/cpuhotplug.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/kernel/irq/cpuhotplug.c b/kernel/irq/cpuhotplug.c
> > index 02236b13b3599..cf8d4f75632e8 100644
> > --- a/kernel/irq/cpuhotplug.c
> > +++ b/kernel/irq/cpuhotplug.c
> > @@ -42,7 +42,7 @@ static inline bool irq_needs_fixup(struct irq_data *d)
> >  		 * If this happens then there was a missed IRQ fixup at some
> >  		 * point. Warn about it and enforce fixup.
> >  		 */
> > -		pr_warn("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n",
> 
> This one is clearly a warning as this should not happen. See the
> comments around that.
> 
> > +		pr_debug("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n",
> >  			cpumask_pr_args(m), d->irq, cpu);
> >  		return true;
> >  	}
> > @@ -166,7 +166,7 @@ void irq_migrate_all_off_this_cpu(void)
> >  		raw_spin_unlock(&desc->lock);
> >  
> >  		if (affinity_broken) {
> > -			pr_warn_ratelimited("IRQ %u: no longer affine to CPU%u\n",
> > +			pr_debug_ratelimited("IRQ %u: no longer affine to CPU%u\n",
> >  					    irq, smp_processor_id());
> 
> Maybe, but distro people might have opinions on that.

The trouble is, even if these are real warnings, they have an affect
on performance on real products.  To the point where so much logging
builds up during pre-release testing, that it sets off the watchdog(s)
on some high profile consumer devices.

What would you suggest?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] genirq/cpuhotplug: Bump debugging information print down to KERN_DEBUG
  2021-08-11  7:57   ` Lee Jones
@ 2021-08-11 12:08     ` Thomas Gleixner
  2021-08-16  7:43       ` Lee Jones
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Gleixner @ 2021-08-11 12:08 UTC (permalink / raw)
  To: Lee Jones; +Cc: linux-arm-kernel, linux-kernel, Ming Lei, Hannes Reinecke

On Wed, Aug 11 2021 at 08:57, Lee Jones wrote:
> On Tue, 10 Aug 2021, Thomas Gleixner wrote:
>> > @@ -42,7 +42,7 @@ static inline bool irq_needs_fixup(struct irq_data *d)
>> >  		 * If this happens then there was a missed IRQ fixup at some
>> >  		 * point. Warn about it and enforce fixup.
>> >  		 */
>> > -		pr_warn("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n",
>> 
>> This one is clearly a warning as this should not happen. See the
>> comments around that.
>> 
>> > +		pr_debug("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n",
>> >  			cpumask_pr_args(m), d->irq, cpu);
>> >  		return true;
>> >  	}
>> > @@ -166,7 +166,7 @@ void irq_migrate_all_off_this_cpu(void)
>> >  		raw_spin_unlock(&desc->lock);
>> >  
>> >  		if (affinity_broken) {
>> > -			pr_warn_ratelimited("IRQ %u: no longer affine to CPU%u\n",
>> > +			pr_debug_ratelimited("IRQ %u: no longer affine to CPU%u\n",
>> >  					    irq, smp_processor_id());
>> 
>> Maybe, but distro people might have opinions on that.
>
> The trouble is, even if these are real warnings, they have an affect
> on performance on real products.  To the point where so much logging
> builds up during pre-release testing, that it sets off the watchdog(s)
> on some high profile consumer devices.

I'm fine with making the second one debug, but the first one really
should not trigger at all.

Thanks,

        tglx

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] genirq/cpuhotplug: Bump debugging information print down to KERN_DEBUG
  2021-08-11 12:08     ` Thomas Gleixner
@ 2021-08-16  7:43       ` Lee Jones
  0 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2021-08-16  7:43 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: linux-arm-kernel, linux-kernel, Ming Lei, Hannes Reinecke

On Wed, 11 Aug 2021, Thomas Gleixner wrote:

> On Wed, Aug 11 2021 at 08:57, Lee Jones wrote:
> > On Tue, 10 Aug 2021, Thomas Gleixner wrote:
> >> > @@ -42,7 +42,7 @@ static inline bool irq_needs_fixup(struct irq_data *d)
> >> >  		 * If this happens then there was a missed IRQ fixup at some
> >> >  		 * point. Warn about it and enforce fixup.
> >> >  		 */
> >> > -		pr_warn("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n",
> >> 
> >> This one is clearly a warning as this should not happen. See the
> >> comments around that.
> >> 
> >> > +		pr_debug("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n",
> >> >  			cpumask_pr_args(m), d->irq, cpu);
> >> >  		return true;
> >> >  	}
> >> > @@ -166,7 +166,7 @@ void irq_migrate_all_off_this_cpu(void)
> >> >  		raw_spin_unlock(&desc->lock);
> >> >  
> >> >  		if (affinity_broken) {
> >> > -			pr_warn_ratelimited("IRQ %u: no longer affine to CPU%u\n",
> >> > +			pr_debug_ratelimited("IRQ %u: no longer affine to CPU%u\n",
> >> >  					    irq, smp_processor_id());
> >> 
> >> Maybe, but distro people might have opinions on that.
> >
> > The trouble is, even if these are real warnings, they have an affect
> > on performance on real products.  To the point where so much logging
> > builds up during pre-release testing, that it sets off the watchdog(s)
> > on some high profile consumer devices.
> 
> I'm fine with making the second one debug, but the first one really
> should not trigger at all.

Understood.  I'll follow-up with a subsequent patch and report back
with your advice.  Thanks Thomas.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-08-16  7:43 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-17  7:31 [PATCH 1/1] genirq/cpuhotplug: Bump debugging information print down to KERN_DEBUG Lee Jones
2021-08-10 14:21 ` Thomas Gleixner
2021-08-11  7:57   ` Lee Jones
2021-08-11 12:08     ` Thomas Gleixner
2021-08-16  7:43       ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).