From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3904EC2B9F4 for ; Thu, 17 Jun 2021 13:37:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B29A613CA for ; Thu, 17 Jun 2021 13:37:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232856AbhFQNjf (ORCPT ); Thu, 17 Jun 2021 09:39:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:35930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231451AbhFQNjW (ORCPT ); Thu, 17 Jun 2021 09:39:22 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D4FA560BD3; Thu, 17 Jun 2021 13:37:13 +0000 (UTC) Date: Thu, 17 Jun 2021 09:37:12 -0400 From: Steven Rostedt To: David Howells Cc: Alexey Dobriyan , akpm@linux-foundation.org, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] afs: fix tracepoint string placement with built-in AFS Message-ID: <20210617093712.25cfa707@gandalf.local.home> In-Reply-To: <1192147.1623931489@warthog.procyon.org.uk> References: <20210615115453.63bc3a63@oasis.local.home> <643721.1623754699@warthog.procyon.org.uk> <1192147.1623931489@warthog.procyon.org.uk> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17 Jun 2021 13:04:49 +0100 David Howells wrote: > Steven Rostedt wrote: > > > Looks fine to me, and even saves 4 bytes on 64 bit machines (events are > > rounded up to 4 byte increments, so the u16 is no different than a u32 > > here). > > Can I put that down as a Reviewed-by? Sure. I was going to recommend consolidating the mappings a bit more to have the enums and numbers defined in a single macro, but then I saw that it matches the rest of the header file, and to do the consolidation would require modifying the existing code, which I thought wasn't worth the effort. Reviewed-by: Steven Rostedt (VMware) -- Steve