From: Gatis Peisenieks <gatis@mikrotik.com>
To: chris.snook@gmail.com, davem@davemloft.net, kuba@kernel.org,
hkallweit1@gmail.com, jesse.brandeburg@intel.com,
dchickles@marvell.com, tully@mikrotik.com,
eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Gatis Peisenieks <gatis@mikrotik.com>
Subject: [PATCH net] atl1c: improve reliability of mdio ops on Mikrotik 10/25G NIC
Date: Thu, 17 Jun 2021 15:25:53 +0300 [thread overview]
Message-ID: <20210617122553.2970190-1-gatis@mikrotik.com> (raw)
MDIO ops on Mikrotik 10/25G NIC can occasionally take longer
to complete. This increases the timeout from 1.2 to 12ms.
Signed-off-by: Gatis Peisenieks <gatis@mikrotik.com>
---
drivers/net/ethernet/atheros/atl1c/atl1c_hw.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_hw.h b/drivers/net/ethernet/atheros/atl1c/atl1c_hw.h
index c567c920628f..15523077490f 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_hw.h
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_hw.h
@@ -290,7 +290,7 @@ void atl1c_post_phy_linkchg(struct atl1c_hw *hw, u16 link_speed);
#define MDIO_CTRL_REG_SHIFT 16
#define MDIO_CTRL_DATA_MASK 0xFFFFUL
#define MDIO_CTRL_DATA_SHIFT 0
-#define MDIO_MAX_AC_TO 120 /* 1.2ms timeout for slow clk */
+#define MDIO_MAX_AC_TO 1200 /* 12ms timeout for slow clk */
/* for extension reg access */
#define REG_MDIO_EXTN 0x1448
--
2.31.1
next reply other threads:[~2021-06-17 12:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 12:25 Gatis Peisenieks [this message]
2021-06-17 14:35 ` [PATCH net] atl1c: improve reliability of mdio ops on Mikrotik 10/25G NIC Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617122553.2970190-1-gatis@mikrotik.com \
--to=gatis@mikrotik.com \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=dchickles@marvell.com \
--cc=eric.dumazet@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tully@mikrotik.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).