From: Guenter Roeck <email@example.com> To: Dmitry Osipenko <firstname.lastname@example.org> Cc: Jean Delvare <email@example.com>, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH v1] hwmon: (lm90) Use edge-triggered interrupt Date: Thu, 17 Jun 2021 14:42:57 -0700 [thread overview] Message-ID: <20210617214257.GD2244035@roeck-us.net> (raw) In-Reply-To: <firstname.lastname@example.org> On Thu, Jun 17, 2021 at 06:27:50PM +0300, Dmitry Osipenko wrote: > 17.06.2021 18:12, Guenter Roeck пишет: > >> For now I see that the rising edge isn't needed, the TEMP_ALERT goes > >> HIGH by itself when temperature backs to normal. But I will try to > >> double check. > >> > > The point is that a sysfs event should be sent to userspace on both > > edges, not only when an alarm is raised. But, you are correct, > > IRQ_TYPE_EDGE_RISING is currently not needed since sysfs events > > are not generated. > > Ok, thank you for the clarification. > > >>> Anyway, the tegra30 dts files in the upstream kernel either use > >>> IRQ_TYPE_LEVEL_LOW or no interrupts for nct1008. The Nexus 7 dts file > >>> in the upstream kernel has no interrupt configured (and coincidentally > >>> it was you who added that entry). Where do you see IRQ_TYPE_LEVEL_HIGH ? > >> I have a patch that will add the interrupt property, it's stashed > >> locally for the next kernel release. > >> > >> IIUC, it's not only the Tegra30 dts, but all the TegraXXX boards that > >> use IRQ_TYPE_LEVEL_LOW are in the same position. > > I still don't see a IRQ_TYPE_LEVEL_HIGH, though. > > Could you please clarify why you're looking for HIGH and not for LOW? > The TEMP_ALERT is active-low. Because you stated earlier: "... cargo-culted and wrong because they use IRQ_TYPE_LEVEL_HIGH ..." ^^^^^^^^^^^^^^^^^^^ Guenter
next prev parent reply other threads:[~2021-06-17 21:43 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-16 19:07 Dmitry Osipenko 2021-06-17 0:12 ` Guenter Roeck 2021-06-17 7:11 ` Dmitry Osipenko 2021-06-17 13:12 ` Guenter Roeck 2021-06-17 13:48 ` Dmitry Osipenko 2021-06-17 14:13 ` Guenter Roeck 2021-06-17 14:46 ` Dmitry Osipenko 2021-06-17 15:12 ` Guenter Roeck 2021-06-17 15:27 ` Dmitry Osipenko 2021-06-17 21:42 ` Guenter Roeck [this message] 2021-06-18 8:55 ` Dmitry Osipenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210617214257.GD2244035@roeck-us.net \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v1] hwmon: (lm90) Use edge-triggered interrupt' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).