From: Steven Rostedt <rostedt@goodmis.org>
To: Daniel Bristot de Oliveira <bristot@redhat.com>
Cc: Phil Auld <pauld@redhat.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Kate Carcia <kcarcia@redhat.com>,
Jonathan Corbet <corbet@lwn.net>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Alexandre Chartre <alexandre.chartre@oracle.com>,
Clark Willaims <williams@redhat.com>,
John Kacur <jkacur@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 10/12] trace: Add osnoise tracer
Date: Fri, 18 Jun 2021 13:55:11 -0400 [thread overview]
Message-ID: <20210618135511.7c06a635@oasis.local.home> (raw)
In-Reply-To: <c555b92d6cfef5b3d05c426696d98553c1a46c8d.1623746916.git.bristot@redhat.com>
On Tue, 15 Jun 2021 11:28:49 +0200
Daniel Bristot de Oliveira <bristot@redhat.com> wrote:
> diff --git a/arch/x86/kernel/trace.c b/arch/x86/kernel/trace.c
> new file mode 100644
> index 000000000000..e67d63657628
> --- /dev/null
> +++ b/arch/x86/kernel/trace.c
> @@ -0,0 +1,238 @@
> +#include <asm/trace/irq_vectors.h>
> +
> +#ifdef CONFIG_OSNOISE_TRACER
> +extern void osnoise_trace_irq_entry(int id);
> +extern void osnoise_trace_irq_exit(int id, const char *desc);
Any reason to have the above outside the LOCAL_APIC def? It's not used.
In fact, this could just be turned into:
#if defined(CONFIG_OSNOISE_TRAECR) && defined(CONFIG_X86_LOCAL_APIC)
-- Steve
> +
> +#ifdef CONFIG_X86_LOCAL_APIC
[..]
> +#endif /* CONFIG_X86_LOCAL_APIC */
> +#endif /* CONFIG_OSNOISE_TRACER */
next prev parent reply other threads:[~2021-06-18 17:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 9:28 [PATCH V4 00/12] hwlat improvements and osnoise/timerlat tracers Daniel Bristot de Oliveira
2021-06-15 9:28 ` [PATCH V4 01/12] trace/hwlat: Fix Clark's email Daniel Bristot de Oliveira
2021-06-15 9:28 ` [PATCH V4 02/12] trace/hwlat: Implement the mode config option Daniel Bristot de Oliveira
2021-06-15 9:28 ` [PATCH V4 03/12] trace/hwlat: Switch disable_migrate to mode none Daniel Bristot de Oliveira
2021-06-15 9:28 ` [PATCH V4 04/12] trace/hwlat: Implement the per-cpu mode Daniel Bristot de Oliveira
2021-06-15 9:28 ` [PATCH V4 05/12] trace/hwlat: Support hotplug operations Daniel Bristot de Oliveira
2021-06-18 16:45 ` Steven Rostedt
2021-06-18 19:00 ` Steven Rostedt
2021-06-21 11:34 ` Daniel Bristot de Oliveira
2021-06-21 15:25 ` Steven Rostedt
2021-06-21 16:14 ` Daniel Bristot de Oliveira
2021-06-21 17:46 ` Steven Rostedt
2021-06-22 14:05 ` Daniel Bristot de Oliveira
2021-06-15 9:28 ` [PATCH V4 06/12] trace: Add a generic function to read/write u64 values from tracefs Daniel Bristot de Oliveira
2021-06-18 16:56 ` Steven Rostedt
2021-06-21 11:50 ` Daniel Bristot de Oliveira
2021-06-15 9:28 ` [PATCH V4 07/12] trace/hwlat: Use trace_min_max_param for width and window params Daniel Bristot de Oliveira
2021-06-15 9:28 ` [PATCH V4 08/12] trace/hwlat: Remove printk from sampling loop Daniel Bristot de Oliveira
2021-06-15 9:28 ` [PATCH V4 09/12] trace: Add __print_ns_to_secs() and __print_ns_without_secs() helpers Daniel Bristot de Oliveira
2021-06-15 9:28 ` [PATCH V4 10/12] trace: Add osnoise tracer Daniel Bristot de Oliveira
2021-06-18 17:55 ` Steven Rostedt [this message]
2021-06-21 12:09 ` Daniel Bristot de Oliveira
2021-06-18 18:27 ` Steven Rostedt
2021-06-21 12:09 ` Daniel Bristot de Oliveira
2021-06-15 9:28 ` [PATCH V4 11/12] trace: Add timerlat tracer Daniel Bristot de Oliveira
2021-06-15 9:28 ` [PATCH V4 12/12] trace/osnoise: Support hotplug operations Daniel Bristot de Oliveira
2021-06-18 19:04 ` Steven Rostedt
2021-06-21 12:18 ` Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210618135511.7c06a635@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=alexandre.chartre@oracle.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=bristot@redhat.com \
--cc=corbet@lwn.net \
--cc=hpa@zytor.com \
--cc=jkacur@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=kcarcia@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).