From: Mark Rutland <mark.rutland@arm.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, benh@kernel.crashing.org,
boqun.feng@gmail.com, bp@alien8.de, catalin.marinas@arm.com,
dvyukov@google.com, elver@google.com, ink@jurassic.park.msu.ru,
jonas@southpole.se, juri.lelli@redhat.com, linux@armlinux.org.uk,
luto@kernel.org, mattst88@gmail.com, mingo@redhat.com,
monstr@monstr.eu, mpe@ellerman.id.au, paulmck@kernel.org,
paulus@samba.org, peterz@infradead.org, rth@twiddle.net,
shorne@gmail.com, stefan.kristiansson@saunalahti.fi,
vincent.guittot@linaro.org, will@kernel.org
Subject: Re: [RFC PATCH 10/10] x86: snapshot thread flags
Date: Mon, 21 Jun 2021 09:35:18 +0100 [thread overview]
Message-ID: <20210621083518.GD37068@C02TD0UTHF1T.local> (raw)
In-Reply-To: <87eecxh4hj.ffs@nanos.tec.linutronix.de>
On Sun, Jun 20, 2021 at 12:30:32AM +0200, Thomas Gleixner wrote:
> On Wed, Jun 09 2021 at 13:20, Mark Rutland wrote:
> > Some thread flags can be set remotely, and so even when IRQs are
> > disabled, the flags can change under our feet. Generally this is
> > unlikely to cause a problem in practice, but it is somewhat unsound, and
> > KCSAN will legitimately warn that there is a data race.
> >
> > To avoid such issues, we should snapshot the flags prior to using them.
> > Let's use the new helpers to do so on x86.
>
> To avoid such issues, a snapshot of the flags has to be taken prior to
> using them. Some places already use READ_ONCE() for that, others do
> not.
>
> Convert them all to the new flag accessor helpers.
I'll use that wording consistently throughout the series.
> Other than that.
>
> Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Thanks!
Mark.
prev parent reply other threads:[~2021-06-21 8:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 12:19 [RFC PATCH 00/10] thread_info: use helpers to snapshot thread flags Mark Rutland
2021-06-09 12:19 ` [RFC PATCH 01/10] thread_info: add " Mark Rutland
2021-06-10 9:01 ` Marco Elver
2021-06-11 9:17 ` Mark Rutland
2021-06-19 22:28 ` Thomas Gleixner
2021-06-21 8:29 ` Mark Rutland
2021-06-09 12:19 ` [RFC PATCH 02/10] entry: " Mark Rutland
2021-06-09 12:19 ` [RFC PATCH 03/10] sched: " Mark Rutland
2021-06-09 12:19 ` [RFC PATCH 04/10] alpha: " Mark Rutland
2021-06-09 12:19 ` [RFC PATCH 05/10] arm: " Mark Rutland
2021-06-09 12:19 ` [RFC PATCH 06/10] arm64: read " Mark Rutland
2021-06-09 12:19 ` [RFC PATCH 07/10] microblaze: snapshot " Mark Rutland
2021-06-09 12:19 ` [RFC PATCH 08/10] openrisc: " Mark Rutland
2021-06-10 19:14 ` Stafford Horne
2021-06-09 12:20 ` [RFC PATCH 09/10] powerpc: " Mark Rutland
2021-06-15 13:18 ` Michael Ellerman
2021-06-21 8:46 ` Mark Rutland
2021-06-09 12:20 ` [RFC PATCH 10/10] x86: " Mark Rutland
2021-06-19 22:30 ` Thomas Gleixner
2021-06-21 8:35 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210621083518.GD37068@C02TD0UTHF1T.local \
--to=mark.rutland@arm.com \
--cc=benh@kernel.crashing.org \
--cc=boqun.feng@gmail.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jonas@southpole.se \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luto@kernel.org \
--cc=mattst88@gmail.com \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=paulmck@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rth@twiddle.net \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).