From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F040C49361 for ; Mon, 21 Jun 2021 08:54:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0756460FE7 for ; Mon, 21 Jun 2021 08:54:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230390AbhFUI5I (ORCPT ); Mon, 21 Jun 2021 04:57:08 -0400 Received: from foss.arm.com ([217.140.110.172]:58774 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230272AbhFUI5H (ORCPT ); Mon, 21 Jun 2021 04:57:07 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A31371FB; Mon, 21 Jun 2021 01:54:53 -0700 (PDT) Received: from bogus (unknown [10.57.36.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1A9C13F718; Mon, 21 Jun 2021 01:54:50 -0700 (PDT) Date: Mon, 21 Jun 2021 09:54:31 +0100 From: Sudeep Holla To: Jassi Brar Cc: Peter Hilber , linux-arm-kernel , Devicetree List , Igor Skalkin , Rob Herring , Linux Kernel Mailing List , souvik.chakravarty@arm.com, alex.bennee@linaro.org, jean-philippe@linaro.org, mikhail.golubev@opensynergy.com, anton.yakovlev@opensynergy.com, Vasyl Vavrychuk , Andriy Tryshnivskyy , Cristian Marussi , Mark Rutland , Sudeep Holla , Lorenzo Pieralisi Subject: Re: [RFC PATCH v3 01/12] firmware: arm_scmi, smccc, mailbox: Make shmem based transports optional Message-ID: <20210621085431.whk5z3gohk3pb6j7@bogus> References: <20210511002040.802226-1-peter.hilber@opensynergy.com> <20210511002040.802226-2-peter.hilber@opensynergy.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 20, 2021 at 11:09:21PM -0500, Jassi Brar wrote: > On Mon, May 10, 2021 at 7:22 PM Peter Hilber > wrote: > > ..... > > > --- a/drivers/mailbox/Kconfig > > +++ b/drivers/mailbox/Kconfig > > @@ -1,6 +1,7 @@ > > # SPDX-License-Identifier: GPL-2.0-only > > menuconfig MAILBOX > > bool "Mailbox Hardware Support" > > + select ARM_SCMI_HAVE_SHMEM > > help > > Mailbox is a framework to control hardware communication between > > on-chip processors through queued messages and interrupt driven > > > Isn't this too generic? > Not all platforms, with a mailbox controller, use SCMI as the protocol. > Yikes! I agree Jassi, this looks super hack. -- Regards, Sudeep