From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BFA4C49EA2 for ; Mon, 21 Jun 2021 09:54:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3AFCB60FF4 for ; Mon, 21 Jun 2021 09:54:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230251AbhFUJ42 (ORCPT ); Mon, 21 Jun 2021 05:56:28 -0400 Received: from elvis.franken.de ([193.175.24.41]:40946 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229663AbhFUJ4Z (ORCPT ); Mon, 21 Jun 2021 05:56:25 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lvGd8-000490-00; Mon, 21 Jun 2021 11:54:10 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 7982FC071C; Mon, 21 Jun 2021 11:53:54 +0200 (CEST) Date: Mon, 21 Jun 2021 11:53:54 +0200 From: Thomas Bogendoerfer To: zhouchuangao Cc: Huacai Chen , Aleksandar Markovic , linux-mips@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mips/kvm: Use BUG_ON instead of if condition followed by BUG Message-ID: <20210621095354.GD4425@alpha.franken.de> References: <1619166910-70744-1-git-send-email-zhouchuangao@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1619166910-70744-1-git-send-email-zhouchuangao@vivo.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 23, 2021 at 01:35:09AM -0700, zhouchuangao wrote: > BUG_ON uses unlikely in if(), it can be optimized at compile time. > > Usually, the condition in if() is not satisfied. In my opinion, > this can improve the efficiency of the multi-stage pipeline. > > Signed-off-by: zhouchuangao > --- > arch/mips/kvm/tlb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]