linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: jpoimboe@redhat.com, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
	joro@8bytes.org, boris.ostrovsky@oracle.com, jgross@suse.com,
	x86@kernel.org, mbenes@suse.com
Subject: [RFC][PATCH 06/18] x86/paravirt: Mark arch_local_irq_*() __always_inline
Date: Mon, 21 Jun 2021 13:12:39 +0200	[thread overview]
Message-ID: <20210621120120.863523024@infradead.org> (raw)
In-Reply-To: 20210621111233.344964031@infradead.org

vmlinux.o: warning: objtool: lockdep_hardirqs_on()+0x72: call to arch_local_save_flags() leaves .noinstr.text section
vmlinux.o: warning: objtool: lockdep_hardirqs_off()+0x73: call to arch_local_save_flags() leaves .noinstr.text section
vmlinux.o: warning: objtool: match_held_lock()+0x11f: call to arch_local_save_flags() leaves .noinstr.text section

vmlinux.o: warning: objtool: lock_is_held_type()+0x4e: call to arch_local_irq_save() leaves .noinstr.text section

vmlinux.o: warning: objtool: lock_is_held_type()+0x65: call to arch_local_irq_disable() leaves .noinstr.text section

vmlinux.o: warning: objtool: lock_is_held_type()+0xfe: call to arch_local_irq_enable() leaves .noinstr.text section

It makes no sense to not inline these things.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
 arch/x86/include/asm/paravirt.h |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

--- a/arch/x86/include/asm/paravirt.h
+++ b/arch/x86/include/asm/paravirt.h
@@ -681,23 +681,23 @@ bool __raw_callee_save___native_vcpu_is_
 	((struct paravirt_callee_save) { func })
 
 #ifdef CONFIG_PARAVIRT_XXL
-static inline notrace unsigned long arch_local_save_flags(void)
+static __always_inline unsigned long arch_local_save_flags(void)
 {
 	return PVOP_ALT_CALLEE0(unsigned long, irq.save_fl, "pushf; pop %%rax;",
 				ALT_NOT(X86_FEATURE_XENPV));
 }
 
-static inline notrace void arch_local_irq_disable(void)
+static __always_inline void arch_local_irq_disable(void)
 {
 	PVOP_ALT_VCALLEE0(irq.irq_disable, "cli;", ALT_NOT(X86_FEATURE_XENPV));
 }
 
-static inline notrace void arch_local_irq_enable(void)
+static __always_inline void arch_local_irq_enable(void)
 {
 	PVOP_ALT_VCALLEE0(irq.irq_enable, "sti;", ALT_NOT(X86_FEATURE_XENPV));
 }
 
-static inline notrace unsigned long arch_local_irq_save(void)
+static __always_inline unsigned long arch_local_irq_save(void)
 {
 	unsigned long f;
 



  parent reply	other threads:[~2021-06-21 12:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-21 11:12 [RFC][PATCH 00/18] objtool/x86: noinstr vs PARAVIRT Peter Zijlstra
2021-06-21 11:12 ` [PATCH 01/18] x86/entry: Fix noinstr fail in __do_fast_syscall_32() Peter Zijlstra
2021-06-22 12:03   ` [tip: objtool/urgent] " tip-bot2 for Peter Zijlstra
2021-06-21 11:12 ` [PATCH 02/18] x86/xen: Fix noinstr fail in xen_pv_evtchn_do_upcall() Peter Zijlstra
2021-06-22 12:03   ` [tip: objtool/urgent] " tip-bot2 for Peter Zijlstra
2021-06-21 11:12 ` [PATCH 03/18] x86/xen: Fix noinstr fail in exc_xen_unknown_trap() Peter Zijlstra
2021-06-22 12:03   ` [tip: objtool/urgent] " tip-bot2 for Peter Zijlstra
2021-06-21 11:12 ` [PATCH 04/18] x86: Always inline task_size_max() Peter Zijlstra
2021-06-22 12:03   ` [tip: objtool/urgent] " tip-bot2 for Peter Zijlstra
2021-06-21 11:12 ` [PATCH 05/18] locking/lockdep: Improve noinstr vs errors Peter Zijlstra
2021-06-22 12:03   ` [tip: objtool/urgent] " tip-bot2 for Peter Zijlstra
2021-06-21 11:12 ` Peter Zijlstra [this message]
2021-06-21 11:12 ` [RFC][PATCH 07/18] x86/paravirt: Use PVOP_* for paravirt calls Peter Zijlstra
2021-06-21 11:12 ` [RFC][PATCH 08/18] x86/xen: Make read_cr2() noinstr Peter Zijlstra
2021-06-21 11:12 ` [RFC][PATCH 09/18] x86/xen: Make write_cr2() noinstr Peter Zijlstra
2021-06-21 11:12 ` [RFC][PATCH 10/18] x86/xen: Make get_debugreg() noinstr Peter Zijlstra
2021-06-21 11:12 ` [RFC][PATCH 11/18] x86/xen: Make set_debugreg() noinstr Peter Zijlstra
2021-06-21 11:12 ` [RFC][PATCH 12/18] x86/xen: Make save_fl() noinstr Peter Zijlstra
2021-06-21 11:12 ` [RFC][PATCH 13/18] x86/xen: Make hypercall_page noinstr Peter Zijlstra
2021-06-21 11:12 ` [RFC][PATCH 14/18] x86/xen: Make irq_enable() noinstr Peter Zijlstra
2021-06-21 11:12 ` [RFC][PATCH 15/18] x86/xen: Make irq_disable() noinstr Peter Zijlstra
2021-06-21 11:12 ` [RFC][PATCH 16/18] x86/xen: Mark xen_force_evtchn_callback() noinstr Peter Zijlstra
2021-06-21 11:12 ` [RFC][PATCH 17/18] x86/xen: Rework the xen_{cpu,irq,mmu}_ops[] arrays Peter Zijlstra
2021-06-21 11:12 ` [RFC][PATCH 18/18] objtool: Support pv_opsindirect calls for noinstr Peter Zijlstra
2021-06-21 13:17 ` [RFC][PATCH 00/18] objtool/x86: noinstr vs PARAVIRT Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210621120120.863523024@infradead.org \
    --to=peterz@infradead.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=joro@8bytes.org \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbenes@suse.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).