Re: [PATCH] drm/vc4: dsi: Only register our component once a DSI device is attached

From: Maxime Ripard <maxime@cerno.tech>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Marek Vasut <marex@denx.de>,
	Tim Gover <tim.gover@raspberrypi.com>,
	Andrzej Hajda <a.hajda@samsung.com>,
	LKML <linux-kernel@vger.kernel.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Eric Anholt <eric@anholt.net>,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	Phil Elwell <phil@raspberrypi.com>,
	Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/vc4: dsi: Only register our component once a DSI device is attached
Date: Mon, 21 Jun 2021 18:06:21 +0200	[thread overview]
Message-ID: <20210621160621.7p7fa7f5m4gct4o2@gilmour> (raw)
In-Reply-To: <YM/FwVkkQXX8VrzV@pendragon.ideasonboard.com>

[-- Attachment #1: Type: text/plain, Size: 2812 bytes --]

Hi,

On Mon, Jun 21, 2021 at 01:48:33AM +0300, Laurent Pinchart wrote:
> Then, when running kmstest --flip, I get one warning per frame:
> 
> [   29.762089] [drm:vc4_dsi_runtime_resume] *ERROR* vc4_dsi_runtime_resume:
> [   29.763200] [drm:vc4_dsi_runtime_resume] *ERROR* vc4_dsi_runtime_resume: All good
> [   29.793861] ------------[ cut here ]------------
> [   29.798572] WARNING: CPU: 2 PID: 249 at drivers/gpu/drm/drm_modeset_lock.c:246 drm_modeset_lock+0xd0/0x100
> [   29.808365] Modules linked in: ipv6 bcm2835_codec(C) bcm2835_unicam bcm2835_v4l2(C) bcm2835_isp(C) bcm2835_mmal_vchiq(C) v4l2_mem2mem v4l2_dv_timings imx296 rtc_ds1307 videobuf2_vmallom
> [   29.855284] CPU: 2 PID: 249 Comm: kworker/u8:10 Tainted: G         C        5.10.44-v8+ #23
> [   29.863756] Hardware name: Raspberry Pi Compute Module 4 Rev 1.0 (DT)
> [   29.870297] Workqueue: events_unbound commit_work
> [   29.875077] pstate: 80000005 (Nzcv daif -PAN -UAO -TCO BTYPE=--)
> [   29.881172] pc : drm_modeset_lock+0xd0/0x100
> [   29.885506] lr : drm_atomic_get_new_or_current_crtc_state+0x6c/0x110
> [   29.891950] sp : ffffffc011fcbcb0
> [   29.895308] x29: ffffffc011fcbcb0 x28: ffffff80403fe780
> [   29.900705] x27: ffffff80415a2000 x26: ffffffc0106f0000
> [   29.906100] x25: 0000000000000000 x24: ffffff80420d3c80
> [   29.911495] x23: ffffff8042174080 x22: 0000000000000038
> [   29.916890] x21: 0000000000000000 x20: ffffff80421740a8
> [   29.922284] x19: ffffffc011f8bc50 x18: 0000000000000000
> [   29.927678] x17: 0000000000000000 x16: 0000000000000000
> [   29.933072] x15: 0000000000000000 x14: 0000000000000000
> [   29.938466] x13: 0048000000000329 x12: 0326032303290320
> [   29.943860] x11: 03200000020301f4 x10: 00000000000019e0
> [   29.949255] x9 : ffffffc0106efd8c x8 : ffffff804390d5c0
> [   29.954649] x7 : 7fffffffffffffff x6 : 0000000000000001
> [   29.960043] x5 : 0000000000000001 x4 : 0000000000000001
> [   29.965436] x3 : ffffff80415a2000 x2 : ffffff804199b200
> [   29.970830] x1 : 00000000000000bc x0 : ffffffc011f8bc98
> [   29.976225] Call trace:
> [   29.978708]  drm_modeset_lock+0xd0/0x100
> [   29.982687]  drm_atomic_get_new_or_current_crtc_state+0x6c/0x110
> [   29.988781]  vc4_atomic_complete_commit+0x4e4/0x860
> [   29.993729]  commit_work+0x18/0x20
> [   29.997181]  process_one_work+0x1c4/0x4a0
> [   30.001248]  worker_thread+0x50/0x420
> [   30.004965]  kthread+0x11c/0x150
> [   30.008239]  ret_from_fork+0x10/0x20
> [   30.011865] ---[ end trace f44ae6b09cda951a ]---
> 
> Does it ring any bell ?
> 
> In case this is useful information, the problem didn't occur on top of
> commit e1499baa0b0c.

I think I have a fix here:
https://github.com/raspberrypi/linux/pull/4402

I haven't tested kmstest --flip yet though

maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]