From: Dmitry Osipenko <digetx@gmail.com>
To: Zhang Rui <rui.zhang@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: [PATCH v4 0/2] Support temperature trips by HWMON core and LM90 driver
Date: Tue, 22 Jun 2021 00:31:51 +0300 [thread overview]
Message-ID: <20210621213153.28247-1-digetx@gmail.com> (raw)
Hi,
It's typical for embedded devices to use LM90-compatible sensor for
monitoring of CPU core and skin temperatures. The sensor is often
used by thermal zone that performs passive cooling and emergency
shutdown on overheat, hence it's more optimal to use interrupt for
a faster notification about temperature changes. Thermal framework
provides set_trips() callback for programming of temperature trips,
let's support it by HWMON.
Changelog:
v4: - Extended commit message of the set_trips() patch, saying that
it has no effect on sensors that can't set trips. This was
suggested by Guenter Roeck.
- The channels are now iterated starting from 0 instead of 1 in the
set_trips() callback. This was suggested by Guenter Roeck.
- Moved out declaration of the err variable into the upper scope of
set_trips(), like it was suggested by Guenter Roeck. The checkpatch
normally warns about missing empty line after a declaration, but it
couldn't detect this case here.
- Replaced the err < 0 comparisons with err != 0, since write callback
of the chip ops isn't supposed to return positive values. This was
suggested by Guenter Roeck.
v3: - Improved patch that fixes integer overflows by fixing the hysteresis
underflow and improving the commit message, telling that min/max/crit
fixes are only related to the LM99 sensor. Thanks to Guenter Roeck
for the suggestion.
v2: - Reworked set_trips() by making it generic. Now callback invokes
the min/max temperature write method directly, instead of using
additional new hwmon callback. This was suggested by Guenter Roeck.
- Added new patch that fixes integer overflows in the LM90 driver.
The fixes are necessary for supporting set_trips().
Dmitry Osipenko (2):
hwmon: (lm90) Prevent integer underflows of temperature calculations
hwmon: Support set_trips() of thermal device ops
drivers/hwmon/hwmon.c | 33 +++++++++++++++++++++++++++++++++
drivers/hwmon/lm90.c | 9 +++++++++
2 files changed, 42 insertions(+)
--
2.30.2
next reply other threads:[~2021-06-21 21:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 21:31 Dmitry Osipenko [this message]
2021-06-21 21:31 ` [PATCH v4 1/2] hwmon: (lm90) Prevent integer underflows of temperature calculations Dmitry Osipenko
2021-06-22 23:15 ` Guenter Roeck
2021-06-21 21:31 ` [PATCH v4 2/2] hwmon: Support set_trips() of thermal device ops Dmitry Osipenko
2021-06-22 23:17 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210621213153.28247-1-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).