From: Shreyansh Chouhan <chouhan.shreyansh630@gmail.com>
To: axboe@kernel.dk
Cc: Shreyansh Chouhan <chouhan.shreyansh630@gmail.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+cf89d662483d6a1a0790@syzkaller.appspotmail.com
Subject: [RESEND PATCH] loop: fix setting arbitrarily large block size
Date: Wed, 23 Jun 2021 10:39:33 +0530 [thread overview]
Message-ID: <20210623050933.140572-1-chouhan.shreyansh630@gmail.com> (raw)
In-Reply-To: <20210622161019.130090-1-chouhan.shreyansh630@gmail.com>
REASON FOR RESEND: Fixed spelling of the Reported-by tag.
loop_validate_block_size took an unsigned short argument. Passing an
argument with size greater than the size of unsigned short would cause
an overflow and could potentially render the upper bound check on the
block size useless, allowing to set an arbitrarily large block size.
Reported-by: syzbot+cf89d662483d6a1a0790@syzkaller.appspotmail.com
Signed-off-by: Shreyansh Chouhan <chouhan.shreyansh630@gmail.com>
---
drivers/block/loop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 9a758cf66507..635baff0dd66 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -236,7 +236,7 @@ static void __loop_update_dio(struct loop_device *lo, bool dio)
* @bsize: size to validate
*/
static int
-loop_validate_block_size(unsigned short bsize)
+loop_validate_block_size(unsigned long bsize)
{
if (bsize < 512 || bsize > PAGE_SIZE || !is_power_of_2(bsize))
return -EINVAL;
--
2.31.1
next prev parent reply other threads:[~2021-06-23 5:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 16:10 [PATCH] loop: fix setting arbitrarily large block size Shreyansh Chouhan
2021-06-23 5:09 ` Shreyansh Chouhan [this message]
2021-06-24 6:14 ` [RESEND PATCH] " Christoph Hellwig
2021-06-26 8:24 ` [PATCH v2] " Shreyansh Chouhan
2021-06-28 5:34 ` Christoph Hellwig
2021-07-20 7:25 ` Shreyansh Chouhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210623050933.140572-1-chouhan.shreyansh630@gmail.com \
--to=chouhan.shreyansh630@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+cf89d662483d6a1a0790@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).