From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2E22C48BC2 for ; Wed, 23 Jun 2021 12:52:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AEC3A610F7 for ; Wed, 23 Jun 2021 12:52:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230263AbhFWMyi (ORCPT ); Wed, 23 Jun 2021 08:54:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:33008 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230163AbhFWMyg (ORCPT ); Wed, 23 Jun 2021 08:54:36 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EB29361076; Wed, 23 Jun 2021 12:52:18 +0000 (UTC) Date: Wed, 23 Jun 2021 08:52:17 -0400 From: Steven Rostedt To: Krzysztof Kozlowski Cc: Ingo Molnar , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/ftrace: fix event-no-pid on 1-core machine Message-ID: <20210623085217.036b7e8d@gandalf.local.home> In-Reply-To: <20210623070431.16592-1-krzysztof.kozlowski@canonical.com> References: <20210623070431.16592-1-krzysztof.kozlowski@canonical.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 23 Jun 2021 09:04:31 +0200 Krzysztof Kozlowski wrote: > When running event-no-pid test on a small machines (e.g. cloud 1-core > instance), other events might not happen: > > + cat trace > + cnt=0 > + [ 0 -eq 0 ] > + fail No other events were recorded > [15] event tracing - restricts events based on pid notrace filtering [FAIL] Acked-by: Steven Rostedt (VMware) Shua, do you want to take this? -- Steve > > Schedule a simple sleep task to be sure that some other process events > get recorder. > > Fixes: ebed9628f5c2 ("selftests/ftrace: Add test to test new set_event_notrace_pid file") > Signed-off-by: Krzysztof Kozlowski > --- > .../testing/selftests/ftrace/test.d/event/event-no-pid.tc | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc b/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc > index e6eb78f0b954..9933ed24f901 100644 > --- a/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc > +++ b/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc > @@ -57,6 +57,10 @@ enable_events() { > echo 1 > tracing_on > } > > +other_task() { > + sleep .001 || usleep 1 || sleep 1 > +} > + > echo 0 > options/event-fork > > do_reset > @@ -94,6 +98,9 @@ child=$! > echo "child = $child" > wait $child > > +# Be sure some other events will happen for small systems (e.g. 1 core) > +other_task > + > echo 0 > tracing_on > > cnt=`count_pid $mypid`