* [PATCH] mmc: sdhci-pci-gli: Finetune GL9763E L1 Entry Delay
@ 2021-06-24 2:56 Renius Chen
2021-06-30 12:19 ` Adrian Hunter
2021-06-30 15:15 ` Ulf Hansson
0 siblings, 2 replies; 5+ messages in thread
From: Renius Chen @ 2021-06-24 2:56 UTC (permalink / raw)
To: ulf.hansson, adrian.hunter
Cc: linux-mmc, linux-kernel, Ben.Chuang, Renius Chen
Finetune the L1 entry delay to 20us for better balance of performance and
battery life.
Signed-off-by: Renius Chen <reniuschengl@gmail.com>
---
drivers/mmc/host/sdhci-pci-gli.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
index 302a7579a9b3..4e3c0561354d 100644
--- a/drivers/mmc/host/sdhci-pci-gli.c
+++ b/drivers/mmc/host/sdhci-pci-gli.c
@@ -90,7 +90,7 @@
#define PCIE_GLI_9763E_CFG2 0x8A4
#define GLI_9763E_CFG2_L1DLY GENMASK(28, 19)
-#define GLI_9763E_CFG2_L1DLY_MID 0x54
+#define GLI_9763E_CFG2_L1DLY_MID 0x50
#define PCIE_GLI_9763E_MMC_CTRL 0x960
#define GLI_9763E_HS400_SLOW BIT(3)
@@ -810,7 +810,7 @@ static void gli_set_gl9763e(struct sdhci_pci_slot *slot)
pci_read_config_dword(pdev, PCIE_GLI_9763E_CFG2, &value);
value &= ~GLI_9763E_CFG2_L1DLY;
- /* set ASPM L1 entry delay to 21us */
+ /* set ASPM L1 entry delay to 20us */
value |= FIELD_PREP(GLI_9763E_CFG2_L1DLY, GLI_9763E_CFG2_L1DLY_MID);
pci_write_config_dword(pdev, PCIE_GLI_9763E_CFG2, value);
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: sdhci-pci-gli: Finetune GL9763E L1 Entry Delay
2021-06-24 2:56 [PATCH] mmc: sdhci-pci-gli: Finetune GL9763E L1 Entry Delay Renius Chen
@ 2021-06-30 12:19 ` Adrian Hunter
2021-06-30 15:15 ` Ulf Hansson
1 sibling, 0 replies; 5+ messages in thread
From: Adrian Hunter @ 2021-06-30 12:19 UTC (permalink / raw)
To: Renius Chen, ulf.hansson; +Cc: linux-mmc, linux-kernel, Ben.Chuang
On 24/06/21 5:56 am, Renius Chen wrote:
> Finetune the L1 entry delay to 20us for better balance of performance and
> battery life.
>
> Signed-off-by: Renius Chen <reniuschengl@gmail.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-pci-gli.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> index 302a7579a9b3..4e3c0561354d 100644
> --- a/drivers/mmc/host/sdhci-pci-gli.c
> +++ b/drivers/mmc/host/sdhci-pci-gli.c
> @@ -90,7 +90,7 @@
>
> #define PCIE_GLI_9763E_CFG2 0x8A4
> #define GLI_9763E_CFG2_L1DLY GENMASK(28, 19)
> -#define GLI_9763E_CFG2_L1DLY_MID 0x54
> +#define GLI_9763E_CFG2_L1DLY_MID 0x50
>
> #define PCIE_GLI_9763E_MMC_CTRL 0x960
> #define GLI_9763E_HS400_SLOW BIT(3)
> @@ -810,7 +810,7 @@ static void gli_set_gl9763e(struct sdhci_pci_slot *slot)
>
> pci_read_config_dword(pdev, PCIE_GLI_9763E_CFG2, &value);
> value &= ~GLI_9763E_CFG2_L1DLY;
> - /* set ASPM L1 entry delay to 21us */
> + /* set ASPM L1 entry delay to 20us */
> value |= FIELD_PREP(GLI_9763E_CFG2_L1DLY, GLI_9763E_CFG2_L1DLY_MID);
> pci_write_config_dword(pdev, PCIE_GLI_9763E_CFG2, value);
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: sdhci-pci-gli: Finetune GL9763E L1 Entry Delay
2021-06-24 2:56 [PATCH] mmc: sdhci-pci-gli: Finetune GL9763E L1 Entry Delay Renius Chen
2021-06-30 12:19 ` Adrian Hunter
@ 2021-06-30 15:15 ` Ulf Hansson
2021-07-01 3:41 ` Renius Chen
1 sibling, 1 reply; 5+ messages in thread
From: Ulf Hansson @ 2021-06-30 15:15 UTC (permalink / raw)
To: Renius Chen
Cc: Adrian Hunter, linux-mmc, Linux Kernel Mailing List, Ben Chuang
On Thu, 24 Jun 2021 at 04:56, Renius Chen <reniuschengl@gmail.com> wrote:
>
> Finetune the L1 entry delay to 20us for better balance of performance and
> battery life.
>
> Signed-off-by: Renius Chen <reniuschengl@gmail.com>
> ---
> drivers/mmc/host/sdhci-pci-gli.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> index 302a7579a9b3..4e3c0561354d 100644
> --- a/drivers/mmc/host/sdhci-pci-gli.c
> +++ b/drivers/mmc/host/sdhci-pci-gli.c
> @@ -90,7 +90,7 @@
>
> #define PCIE_GLI_9763E_CFG2 0x8A4
> #define GLI_9763E_CFG2_L1DLY GENMASK(28, 19)
> -#define GLI_9763E_CFG2_L1DLY_MID 0x54
> +#define GLI_9763E_CFG2_L1DLY_MID 0x50
We just changed from 21us to 20us. Really, how big of a difference can
this make?
Moreover, I suppose the difference is related to the running use case. No?
If you really want this, at least I want an ack from Ben for it, then
let's be done with it.
Kind regards
Uffe
>
> #define PCIE_GLI_9763E_MMC_CTRL 0x960
> #define GLI_9763E_HS400_SLOW BIT(3)
> @@ -810,7 +810,7 @@ static void gli_set_gl9763e(struct sdhci_pci_slot *slot)
>
> pci_read_config_dword(pdev, PCIE_GLI_9763E_CFG2, &value);
> value &= ~GLI_9763E_CFG2_L1DLY;
> - /* set ASPM L1 entry delay to 21us */
> + /* set ASPM L1 entry delay to 20us */
> value |= FIELD_PREP(GLI_9763E_CFG2_L1DLY, GLI_9763E_CFG2_L1DLY_MID);
> pci_write_config_dword(pdev, PCIE_GLI_9763E_CFG2, value);
>
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: sdhci-pci-gli: Finetune GL9763E L1 Entry Delay
2021-06-30 15:15 ` Ulf Hansson
@ 2021-07-01 3:41 ` Renius Chen
2021-07-02 1:29 ` Ben Chuang
0 siblings, 1 reply; 5+ messages in thread
From: Renius Chen @ 2021-07-01 3:41 UTC (permalink / raw)
To: Ulf Hansson
Cc: Adrian Hunter, linux-mmc, Linux Kernel Mailing List, Ben Chuang
Ulf Hansson <ulf.hansson@linaro.org> 於 2021年6月30日 週三 下午11:16寫道：
>
> On Thu, 24 Jun 2021 at 04:56, Renius Chen <reniuschengl@gmail.com> wrote:
> >
> > Finetune the L1 entry delay to 20us for better balance of performance and
> > battery life.
> >
> > Signed-off-by: Renius Chen <reniuschengl@gmail.com>
> > ---
> > drivers/mmc/host/sdhci-pci-gli.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> > index 302a7579a9b3..4e3c0561354d 100644
> > --- a/drivers/mmc/host/sdhci-pci-gli.c
> > +++ b/drivers/mmc/host/sdhci-pci-gli.c
> > @@ -90,7 +90,7 @@
> >
> > #define PCIE_GLI_9763E_CFG2 0x8A4
> > #define GLI_9763E_CFG2_L1DLY GENMASK(28, 19)
> > -#define GLI_9763E_CFG2_L1DLY_MID 0x54
> > +#define GLI_9763E_CFG2_L1DLY_MID 0x50
>
> We just changed from 21us to 20us. Really, how big of a difference can
> this make?
>
> Moreover, I suppose the difference is related to the running use case. No?
>
> If you really want this, at least I want an ack from Ben for it, then
> let's be done with it.
>
> Kind regards
> Uffe
>
Yes, according to the result of our customer's PLT test for battery life,
It will pass the test with 20us and will not pass the test with 21us.
I'll ask Ben for acking this, thank you.
> >
> > #define PCIE_GLI_9763E_MMC_CTRL 0x960
> > #define GLI_9763E_HS400_SLOW BIT(3)
> > @@ -810,7 +810,7 @@ static void gli_set_gl9763e(struct sdhci_pci_slot *slot)
> >
> > pci_read_config_dword(pdev, PCIE_GLI_9763E_CFG2, &value);
> > value &= ~GLI_9763E_CFG2_L1DLY;
> > - /* set ASPM L1 entry delay to 21us */
> > + /* set ASPM L1 entry delay to 20us */
> > value |= FIELD_PREP(GLI_9763E_CFG2_L1DLY, GLI_9763E_CFG2_L1DLY_MID);
> > pci_write_config_dword(pdev, PCIE_GLI_9763E_CFG2, value);
> >
> > --
> > 2.27.0
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: sdhci-pci-gli: Finetune GL9763E L1 Entry Delay
2021-07-01 3:41 ` Renius Chen
@ 2021-07-02 1:29 ` Ben Chuang
0 siblings, 0 replies; 5+ messages in thread
From: Ben Chuang @ 2021-07-02 1:29 UTC (permalink / raw)
To: reniuschengl
Cc: ben.chuang, adrian.hunter, linux-kernel, linux-mmc, ulf.hansson,
Ben Chuang
Hi Ulf and Renius,
> Ulf Hansson <ulf.hansson@linaro.org> 於 2021年6月30日 週三 下午11:16寫道：
> >
> > On Thu, 24 Jun 2021 at 04:56, Renius Chen <reniuschengl@gmail.com> wrote:
> > >
> > > Finetune the L1 entry delay to 20us for better balance of performance and
> > > battery life.
> > >
> > > Signed-off-by: Renius Chen <reniuschengl@gmail.com>
> > > ---
> > > drivers/mmc/host/sdhci-pci-gli.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> > > index 302a7579a9b3..4e3c0561354d 100644
> > > --- a/drivers/mmc/host/sdhci-pci-gli.c
> > > +++ b/drivers/mmc/host/sdhci-pci-gli.c
> > > @@ -90,7 +90,7 @@
> > >
> > > #define PCIE_GLI_9763E_CFG2 0x8A4
> > > #define GLI_9763E_CFG2_L1DLY GENMASK(28, 19)
> > > -#define GLI_9763E_CFG2_L1DLY_MID 0x54
> > > +#define GLI_9763E_CFG2_L1DLY_MID 0x50
> >
> > We just changed from 21us to 20us. Really, how big of a difference can
> > this make?
> >
> > Moreover, I suppose the difference is related to the running use case. No?
> >
> > If you really want this, at least I want an ack from Ben for it, then
> > let's be done with it.
> >
> > Kind regards
> > Uffe
> >
> Yes, according to the result of our customer's PLT test for battery life,
> It will pass the test with 20us and will not pass the test with 21us.
> I'll ask Ben for acking this, thank you.
Using 20us can pass the battery life testing, but need to consider that it
may reduce some performance.
So this patch should be together with 4k patch or after 4k patch.
Then I can acked Acked-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>.
Best regards,
Ben
>
> > >
> > > #define PCIE_GLI_9763E_MMC_CTRL 0x960
> > > #define GLI_9763E_HS400_SLOW BIT(3)
> > > @@ -810,7 +810,7 @@ static void gli_set_gl9763e(struct sdhci_pci_slot *slot)
> > >
> > > pci_read_config_dword(pdev, PCIE_GLI_9763E_CFG2, &value);
> > > value &= ~GLI_9763E_CFG2_L1DLY;
> > > - /* set ASPM L1 entry delay to 21us */
> > > + /* set ASPM L1 entry delay to 20us */
> > > value |= FIELD_PREP(GLI_9763E_CFG2_L1DLY, GLI_9763E_CFG2_L1DLY_MID);
> > > pci_write_config_dword(pdev, PCIE_GLI_9763E_CFG2, value);
> > >
> > > --
> > > 2.27.0
> > >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-07-02 1:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-24 2:56 [PATCH] mmc: sdhci-pci-gli: Finetune GL9763E L1 Entry Delay Renius Chen
2021-06-30 12:19 ` Adrian Hunter
2021-06-30 15:15 ` Ulf Hansson
2021-07-01 3:41 ` Renius Chen
2021-07-02 1:29 ` Ben Chuang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).