From: Kwon Tae-young <tykwon@m2i.co.kr>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Kwon Tae-young <tykwon@m2i.co.kr>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] mmc: core: Added support for LED trigger only when SD card is connected
Date: Thu, 24 Jun 2021 15:14:17 +0900 [thread overview]
Message-ID: <20210624061418.30361-1-tykwon@m2i.co.kr> (raw)
led_trigger_event() is always called.
In this case, if the LED trigger is set to the SD Card, the trigger
will occur even when the SD card is not connected and the LED will blink.
In case of SD Card, it is judged based on Card Detection information and
changes to generate LED trigger only when SD Card is connected.
Board tested: NXP i.MX 8M board
Signed-off-by: Kwon Tae-young <tykwon@m2i.co.kr>
---
drivers/mmc/core/core.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index f194940c5974..b3156f6c5cfa 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -352,7 +352,11 @@ int mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
if (err)
return err;
- led_trigger_event(host->led, LED_FULL);
+ if (host->ops->get_cd)
+ host->ops->get_cd(host) ? led_trigger_event(host->led, LED_FULL) : NULL;
+ else
+ led_trigger_event(host->led, LED_FULL);
+
__mmc_start_request(host, mrq);
return 0;
--
2.17.1
next reply other threads:[~2021-06-24 6:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 6:14 Kwon Tae-young [this message]
2021-06-24 12:21 ` [PATCH] mmc: core: Added support for LED trigger only when SD card is connected Ulf Hansson
2021-06-25 5:43 ` Kwon Tae-young
2021-09-03 6:17 ` 권태영
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210624061418.30361-1-tykwon@m2i.co.kr \
--to=tykwon@m2i.co.kr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).