From: 13145886936@163.com
To: linux@armlinux.org.uk
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
gushengxian <gushengxian@yulong.com>
Subject: [PATCH] ARM: pxa: ssp: remove unnecessary print function dev_err()
Date: Thu, 24 Jun 2021 02:51:06 -0700 [thread overview]
Message-ID: <20210624095106.392317-1-13145886936@163.com> (raw)
From: gushengxian <gushengxian@yulong.com>
The print function dev_err() is redundant because
platform_get_irq() already prints an error.
Signed-off-by: gushengxian <gushengxian@yulong.com>
---
arch/arm/plat-pxa/ssp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c
index 563440315acd..9e77b3392c1e 100644
--- a/arch/arm/plat-pxa/ssp.c
+++ b/arch/arm/plat-pxa/ssp.c
@@ -146,10 +146,8 @@ static int pxa_ssp_probe(struct platform_device *pdev)
}
ssp->irq = platform_get_irq(pdev, 0);
- if (ssp->irq < 0) {
- dev_err(dev, "no IRQ resource defined\n");
+ if (ssp->irq < 0)
return -ENODEV;
- }
if (dev->of_node) {
const struct of_device_id *id =
--
2.25.1
next reply other threads:[~2021-06-24 9:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 9:51 13145886936 [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-06-24 2:41 [PATCH] ARM: pxa: ssp: remove unnecessary print function dev_err() 13145886936
2021-06-24 9:24 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210624095106.392317-1-13145886936@163.com \
--to=13145886936@163.com \
--cc=gushengxian@yulong.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).