From: Rob Herring <robh@kernel.org>
To: Wenbin Mei <wenbin.mei@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Seiya Wang <seiya.wang@mediatek.com>,
devicetree@vger.kernel.org, linux-mmc@vger.kernel.org,
srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org,
Chaotian Jing <chaotian.jing@mediatek.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH v1] dt-bindings: mmc: change compatiable string for MT8195 mmc host IP
Date: Thu, 24 Jun 2021 14:46:55 -0600 [thread overview]
Message-ID: <20210624204655.GA1960751@robh.at.kernel.org> (raw)
In-Reply-To: <1623726033-16073-2-git-send-email-wenbin.mei@mediatek.com>
On Tue, 15 Jun 2021 11:00:33 +0800, Wenbin Mei wrote:
> MT8195 mmc host IP is compatible with MT8183, and currently it shows:
> properties:
> compatible:
> oneOf:
> ...
> - items:
> - const: mediatek,mt8192-mmc
> - const: mediatek,mt8195-mmc
> - const: mediatek,mt8183-mmc
> which means the compatible string in the device tree would be:
> compatible = "mediatek,mt8192-mmc", "mediatek,mt8195-mmc",
> "mediatek,mt8183-mmc";
> The bindings is wrong and that isn't the result we want.
> instead we want:
> properties:
> compatible:
> oneOf:
> ...
> - items:
> - const: mediatek,mt8192-mmc
> - const: mediatek,mt8183-mmc
> - items:
> - const: mediatek,mt8195-mmc
> - const: mediatek,mt8183-mmc
> which would give us:
> compatible = "mediatek,mt8192-mmc", "mediatek,mt8183-mmc";
> and
> compatible = "mediatek,mt8195-mmc", "mediatek,mt8183-mmc";
>
> Fixes: eb9cb7227e5c (dt-bindings: mmc: Add compatible for Mediatek MT8195)
> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> ---
> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2021-06-24 20:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 3:00 [PATCH v1] Change compatiable string for MT8195 mmc host IP Wenbin Mei
2021-06-15 3:00 ` [PATCH v1] dt-bindings: mmc: change " Wenbin Mei
2021-06-24 20:46 ` Rob Herring [this message]
2021-06-29 15:09 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210624204655.GA1960751@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=chaotian.jing@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=seiya.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=ulf.hansson@linaro.org \
--cc=wenbin.mei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).