From: Marek Behun <marek.behun@nic.cz>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: "Pavel Machek" <pavel@ucw.cz>, "Rob Herring" <robh+dt@kernel.org>,
"Andy Gross" <agross@kernel.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lee Jones" <lee.jones@linaro.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-pwm@vger.kernel.org,
"Marijn Suijten" <marijn.suijten@somainline.org>,
"Yassine Oudjana" <y.oudjana@protonmail.com>,
"Luca Weiss" <luca@z3ntu.xyz>,
"Subbaraman Narayanamurthy" <subbaram@codeaurora.org>
Subject: Re: [PATCH v9 1/2] dt-bindings: leds: Add Qualcomm Light Pulse Generator binding
Date: Fri, 25 Jun 2021 01:19:32 +0200 [thread overview]
Message-ID: <20210625011932.6354e397@thinkpad> (raw)
In-Reply-To: <20210623035039.772660-1-bjorn.andersson@linaro.org>
On Tue, 22 Jun 2021 20:50:38 -0700
Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
The file name should be based on one of the compatible strings, for
example the first one:
qcom,pm8150b-lpg.yaml
> + led@1 {
> + reg = <1>;
> + label = "green:user1";
> + };
`label` is deprecated, please don't use in new bindings in examples.
Instead use color, function and function-enumerator, i.e.
color = <LED_COLOR_ID_GREEN>;
function = LED_FUNCTION_xxx;
function-enumerator = <N>;
next prev parent reply other threads:[~2021-06-24 23:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 3:50 [PATCH v9 1/2] dt-bindings: leds: Add Qualcomm Light Pulse Generator binding Bjorn Andersson
2021-06-23 3:50 ` [PATCH v9 2/2] leds: Add driver for Qualcomm LPG Bjorn Andersson
2021-06-25 13:15 ` Uwe Kleine-König
2021-06-24 21:39 ` [PATCH v9 1/2] dt-bindings: leds: Add Qualcomm Light Pulse Generator binding Rob Herring
2021-06-24 23:19 ` Marek Behun [this message]
2021-06-24 23:44 ` Bjorn Andersson
2021-06-25 8:39 ` Alexander Dahl
2021-09-08 3:39 ` Stephen Boyd
2021-10-06 7:44 ` Alexander Dahl
2021-09-09 15:18 ` Matthias Kaehlcke
2021-10-06 4:12 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210625011932.6354e397@thinkpad \
--to=marek.behun@nic.cz \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=marijn.suijten@somainline.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=subbaram@codeaurora.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=y.oudjana@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).