From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69882C2B9F4 for ; Fri, 25 Jun 2021 04:47:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D1F761417 for ; Fri, 25 Jun 2021 04:47:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230341AbhFYEuE (ORCPT ); Fri, 25 Jun 2021 00:50:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbhFYEuC (ORCPT ); Fri, 25 Jun 2021 00:50:02 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88846C061574 for ; Thu, 24 Jun 2021 21:47:41 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id a127so7044004pfa.10 for ; Thu, 24 Jun 2021 21:47:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=AtTk+6QGKLof6Gu7Ev3cepmH8O53Op63rhLICrg+Eb8=; b=Ypvg0mxaCTrsJqr5D08KpxEGYnjPnrEGE5Lh4jwDezc7RcM4boEj6VNfkBWXT6s2RG cjVNCpIWtse8LclIVCXFHfO2ti1XDt1uetqT5HrM7mGwNdWweyQLrMh7YcG3i/W2581W 6FbDNYtQnoNtDWink9Se4Uyk8MeRqzmTWaavQx4XGEYLgXBbPhTVyDerI9rk26H7X3zC wMEq9P7FRsayfNklJM1ThVWFB9eArF6yf57HXFgd6fE3NrKmhPyAoJ3Hez0/Lh4w8u8l bZ9GNhZYZ8wDl45+l9hZExGj6jg1lLcFLjRW9VVKXkIuUmPJ39vMdQmEk2Y5CAHb3e9M n5YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=AtTk+6QGKLof6Gu7Ev3cepmH8O53Op63rhLICrg+Eb8=; b=XXNmNKmNWUQip4/16jgkMXa96fc1H4wv0kDjG+pH9L3a5EU/uGQPNauNCFEa5aTD9l LS+RMd1EU7WPXeoLuabimYm50hpbqYxG5y/kwOYyrRz5vOfTlWRedOVkpnOWXBUozOWN SA96Ffo/KyvnOGQAX75J8cY+6DsyMFwgUpNmcvIakw20fRoQ7km7AhTDWnrhZHgh0x9V bQpEdLq7vVv+wUqKrqat4xmLIRVlvLkvoY5bHPG9/X86Fd0YP2BIPXPIbfG18JSkqXco 9abxBGNqfo/6EZqPWB+WMtHYPCeP4UZu/UoY2D8bEl2/JDkabjqr7ABBsr1/tFNr9Irw QwUQ== X-Gm-Message-State: AOAM530pUzAcQsfVPkDhEueshqE3Xx+bmT6iemU/PcQn3gixf0DNOe/h Ixrd6Q2VctHZu7mW/C4NyzTy X-Google-Smtp-Source: ABdhPJwUiAiC28y9PI+2/abF+jcevjyqTqZv/OpN1QqH+yTCJOdS3d6tJgjgTSSUsBqDDHj0sKZVPA== X-Received: by 2002:a63:5d66:: with SMTP id o38mr7961955pgm.444.1624596460826; Thu, 24 Jun 2021 21:47:40 -0700 (PDT) Received: from workstation ([120.138.13.204]) by smtp.gmail.com with ESMTPSA id y7sm4487159pfy.153.2021.06.24.21.47.37 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 24 Jun 2021 21:47:40 -0700 (PDT) Date: Fri, 25 Jun 2021 10:17:36 +0530 From: Manivannan Sadhasivam To: Bjorn Andersson Cc: Andy Gross , Ohad Ben-Cohen , Mathieu Poirier , Rob Herring , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] remoteproc: qcom: pas: Add SC8180X adsp, cdsp and mpss Message-ID: <20210625044736.GA4974@workstation> References: <20210608174944.2045215-1-bjorn.andersson@linaro.org> <20210608174944.2045215-2-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210608174944.2045215-2-bjorn.andersson@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 08, 2021 at 10:49:44AM -0700, Bjorn Andersson wrote: > The Qualcomm SC8180X has the typical ADSP, CDSP and MPSS remote > processors operated using the PAS interface, add support for these. > > Attempts to configuring mss.lvl is failing, so a new adsp_data is > provided that skips this resource, for now. > What is the impact of this skipped resource? I guess it is enabled by the bootloader so we can't change it in runtime? > Signed-off-by: Bjorn Andersson Given that adsp remoteproc works without configuring mss power domain, Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > > Changes since v1: > - None > > drivers/remoteproc/qcom_q6v5_pas.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c > index b921fc26cd04..a79bee901e9b 100644 > --- a/drivers/remoteproc/qcom_q6v5_pas.c > +++ b/drivers/remoteproc/qcom_q6v5_pas.c > @@ -689,6 +689,25 @@ static const struct adsp_data mpss_resource_init = { > .ssctl_id = 0x12, > }; > > +static const struct adsp_data sc8180x_mpss_resource = { > + .crash_reason_smem = 421, > + .firmware_name = "modem.mdt", > + .pas_id = 4, > + .has_aggre2_clk = false, > + .auto_boot = false, > + .active_pd_names = (char*[]){ > + "load_state", > + NULL > + }, > + .proxy_pd_names = (char*[]){ > + "cx", > + NULL > + }, > + .ssr_name = "mpss", > + .sysmon_name = "modem", > + .ssctl_id = 0x12, > +}; > + > static const struct adsp_data slpi_resource_init = { > .crash_reason_smem = 424, > .firmware_name = "slpi.mdt", > @@ -811,6 +830,9 @@ static const struct of_device_id adsp_of_match[] = { > { .compatible = "qcom,qcs404-cdsp-pas", .data = &cdsp_resource_init }, > { .compatible = "qcom,qcs404-wcss-pas", .data = &wcss_resource_init }, > { .compatible = "qcom,sc7180-mpss-pas", .data = &mpss_resource_init}, > + { .compatible = "qcom,sc8180x-adsp-pas", .data = &sm8150_adsp_resource}, > + { .compatible = "qcom,sc8180x-cdsp-pas", .data = &sm8150_cdsp_resource}, > + { .compatible = "qcom,sc8180x-mpss-pas", .data = &sc8180x_mpss_resource}, > { .compatible = "qcom,sdm845-adsp-pas", .data = &adsp_resource_init}, > { .compatible = "qcom,sdm845-cdsp-pas", .data = &cdsp_resource_init}, > { .compatible = "qcom,sdx55-mpss-pas", .data = &sdx55_mpss_resource}, > -- > 2.29.2 >