linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] soc: mediatek: mmsys: Fix missing UFOE component in mt8173 table routing
@ 2021-06-25  6:24 Enric Balletbo i Serra
  2021-06-28  0:35 ` Eizan Miyamoto
       [not found] ` <CAOak1e_z2Mr-OR3+ECvA_6VToMVptGczoMwsWpfJLVvkvJsDow@mail.gmail.com>
  0 siblings, 2 replies; 3+ messages in thread
From: Enric Balletbo i Serra @ 2021-06-25  6:24 UTC (permalink / raw)
  To: linux-kernel
  Cc: eizan, linux-mediatek, matthias.bgg, drinkcat, hsinyi,
	Collabora Kernel ML, CK Hu, linux-arm-kernel

The UFOE (data compression engine) component needs to be enabled to have
the imgtec gpu driver working. If we don't enable it we see a black screen.
Looks like when we switched to use and array for setting the routing
registers in commit 440147639ac7 ("soc: mediatek: mmsys: Use an array for
setting the routing registers") we missed to add this component in the new
routing table, it was present before taht commit, so fix it by adding
this component in the mt8173 routing table.

Fixes: 440147639ac7 ("soc: mediatek: mmsys: Use an array for setting the routing registers")
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---

 drivers/soc/mediatek/mtk-mmsys.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/soc/mediatek/mtk-mmsys.h b/drivers/soc/mediatek/mtk-mmsys.h
index a760a34e6eca..11388961dded 100644
--- a/drivers/soc/mediatek/mtk-mmsys.h
+++ b/drivers/soc/mediatek/mtk-mmsys.h
@@ -209,6 +209,9 @@ static const struct mtk_mmsys_routes mmsys_default_routing_table[] = {
 	}, {
 		DDP_COMPONENT_RDMA2, DDP_COMPONENT_DSI3,
 		DISP_REG_CONFIG_DSIO_SEL_IN, DSI3_SEL_IN_RDMA2
+	}, {
+		DDP_COMPONENT_UFOE, DDP_COMPONENT_DSI0,
+		DISP_REG_CONFIG_DISP_UFOE_MOUT_EN, UFOE_MOUT_EN_DSI0,
 	}
 };
 
-- 
2.30.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] soc: mediatek: mmsys: Fix missing UFOE component in mt8173 table routing
  2021-06-25  6:24 [PATCH] soc: mediatek: mmsys: Fix missing UFOE component in mt8173 table routing Enric Balletbo i Serra
@ 2021-06-28  0:35 ` Eizan Miyamoto
       [not found] ` <CAOak1e_z2Mr-OR3+ECvA_6VToMVptGczoMwsWpfJLVvkvJsDow@mail.gmail.com>
  1 sibling, 0 replies; 3+ messages in thread
From: Eizan Miyamoto @ 2021-06-28  0:35 UTC (permalink / raw)
  To: Enric Balletbo i Serra
  Cc: LKML, Eizan Miyamoto, moderated list:ARM/Mediatek SoC support,
	Matthias Brugger, drinkcat, hsinyi, Collabora Kernel ML, CK Hu,
	Linux ARM

Dear Enric,

Thanks so much for your hard work bisecting and crafting this patch.

I have verified that it fixes the DRM issues we were seeing on MT8173
with Linux 5.12.

Tested: Eizan Miyamoto <eizan@chromium.org>
On Fri, Jun 25, 2021 at 4:24 PM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> The UFOE (data compression engine) component needs to be enabled to have
> the imgtec gpu driver working. If we don't enable it we see a black screen.
> Looks like when we switched to use and array for setting the routing
> registers in commit 440147639ac7 ("soc: mediatek: mmsys: Use an array for
> setting the routing registers") we missed to add this component in the new
> routing table, it was present before taht commit, so fix it by adding
> this component in the mt8173 routing table.
>
> Fixes: 440147639ac7 ("soc: mediatek: mmsys: Use an array for setting the routing registers")
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
>  drivers/soc/mediatek/mtk-mmsys.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/soc/mediatek/mtk-mmsys.h b/drivers/soc/mediatek/mtk-mmsys.h
> index a760a34e6eca..11388961dded 100644
> --- a/drivers/soc/mediatek/mtk-mmsys.h
> +++ b/drivers/soc/mediatek/mtk-mmsys.h
> @@ -209,6 +209,9 @@ static const struct mtk_mmsys_routes mmsys_default_routing_table[] = {
>         }, {
>                 DDP_COMPONENT_RDMA2, DDP_COMPONENT_DSI3,
>                 DISP_REG_CONFIG_DSIO_SEL_IN, DSI3_SEL_IN_RDMA2
> +       }, {
> +               DDP_COMPONENT_UFOE, DDP_COMPONENT_DSI0,
> +               DISP_REG_CONFIG_DISP_UFOE_MOUT_EN, UFOE_MOUT_EN_DSI0,
>         }
>  };
>
> --
> 2.30.2
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] soc: mediatek: mmsys: Fix missing UFOE component in mt8173 table routing
       [not found] ` <CAOak1e_z2Mr-OR3+ECvA_6VToMVptGczoMwsWpfJLVvkvJsDow@mail.gmail.com>
@ 2021-06-30  7:30   ` Matthias Brugger
  0 siblings, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2021-06-30  7:30 UTC (permalink / raw)
  To: Eizan Miyamoto, Enric Balletbo i Serra
  Cc: linux-kernel, eizan, linux-mediatek, drinkcat, hsinyi,
	Collabora Kernel ML, CK Hu, linux-arm-kernel



On 28/06/2021 02:16, Eizan Miyamoto wrote:
> Dear Enric,
> 
> Thanks so much for your hard work bisecting and crafting this patch.
> 
> I have verified that it fixes the DRM issues we were seeing on MT8173 with
> Linux 5.12.
> 
> Tested: Eizan Miyamoto <eizan@chromium.org>
> 

Applied to v5.13-next/fixes

Thanks!

> On Fri, Jun 25, 2021 at 4:24 PM Enric Balletbo i Serra <
> enric.balletbo@collabora.com> wrote:
> 
>> The UFOE (data compression engine) component needs to be enabled to have
>> the imgtec gpu driver working. If we don't enable it we see a black screen.
>> Looks like when we switched to use and array for setting the routing
>> registers in commit 440147639ac7 ("soc: mediatek: mmsys: Use an array for
>> setting the routing registers") we missed to add this component in the new
>> routing table, it was present before taht commit, so fix it by adding
>> this component in the mt8173 routing table.
>>
>> Fixes: 440147639ac7 ("soc: mediatek: mmsys: Use an array for setting the
>> routing registers")
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>> ---
>>
>>  drivers/soc/mediatek/mtk-mmsys.h | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/soc/mediatek/mtk-mmsys.h
>> b/drivers/soc/mediatek/mtk-mmsys.h
>> index a760a34e6eca..11388961dded 100644
>> --- a/drivers/soc/mediatek/mtk-mmsys.h
>> +++ b/drivers/soc/mediatek/mtk-mmsys.h
>> @@ -209,6 +209,9 @@ static const struct mtk_mmsys_routes
>> mmsys_default_routing_table[] = {
>>         }, {
>>                 DDP_COMPONENT_RDMA2, DDP_COMPONENT_DSI3,
>>                 DISP_REG_CONFIG_DSIO_SEL_IN, DSI3_SEL_IN_RDMA2
>> +       }, {
>> +               DDP_COMPONENT_UFOE, DDP_COMPONENT_DSI0,
>> +               DISP_REG_CONFIG_DISP_UFOE_MOUT_EN, UFOE_MOUT_EN_DSI0,
>>         }
>>  };
>>
>> --
>> 2.30.2
>>
>>
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-30  7:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-25  6:24 [PATCH] soc: mediatek: mmsys: Fix missing UFOE component in mt8173 table routing Enric Balletbo i Serra
2021-06-28  0:35 ` Eizan Miyamoto
     [not found] ` <CAOak1e_z2Mr-OR3+ECvA_6VToMVptGczoMwsWpfJLVvkvJsDow@mail.gmail.com>
2021-06-30  7:30   ` Matthias Brugger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).