From: Drew Fustini <drew@beagleboard.org>
To: Rob Herring <robh@kernel.org>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Michael Zhu <michael.zhu@starfivetech.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Fu Wei <tekkamanninja@gmail.com>,
Emil Renner Berthing <kernel@esmil.dk>,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: riscv: add starfive jh7100 compatibles
Date: Thu, 24 Jun 2021 23:59:28 -0700 [thread overview]
Message-ID: <20210625065928.GA567037@x1> (raw)
In-Reply-To: <20210624212018.GA2003868@robh.at.kernel.org>
On Thu, Jun 24, 2021 at 03:20:18PM -0600, Rob Herring wrote:
> On Wed, Jun 16, 2021 at 01:27:00PM -0700, Drew Fustini wrote:
> > Add DT binding documentation for the StarFive JH7100 Soc [1] and the
> > BeagleV Starlight JH7100 board [2].
> >
> > [1] https://github.com/starfive-tech/beaglev_doc
> > [2] https://github.com/beagleboard/beaglev-starlight
> >
> > Signed-off-by: Drew Fustini <drew@beagleboard.org>
> > ---
> > Note: my patch to add 'starfive' to vendor-prefixes.yaml was applied by
> > Rob back on June 2:
> > https://lore.kernel.org/linux-devicetree/20210602163200.GA3513985@robh.at.kernel.org/
> >
> > I ran dt_binding_check and dtbs_check:
> >
> > $ make -j8 ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- dt_binding_check \
> > DT_SCHEMA_FILES=Documentation/devicetree/bindings/riscv/starfive.yaml
> > CHKDT Documentation/devicetree/bindings/processed-schema-examples.json
> > SCHEMA Documentation/devicetree/bindings/processed-schema-examples.json
> > DTC Documentation/devicetree/bindings/riscv/starfive.example.dt.yaml
> > CHECK Documentation/devicetree/bindings/riscv/starfive.example.dt.yaml
> >
> > $ make -j8 ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- dtbs_check \
> > DT_SCHEMA_FILES=Documentation/devicetree/bindings/riscv/starfive.yaml
> > SCHEMA Documentation/devicetree/bindings/processed-schema.json
> > DTC arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dt.yaml
> > CHECK arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dt.yaml
> >
> > The files jh7100.dtsi and jh7100-beaglev-starlight.dts are in the
> > process of being cleaned up for submission. The current downstream is:
> > https://github.com/starfive-tech/linux/tree/beaglev/arch/riscv/boot/dts/starfive
> >
> > .../devicetree/bindings/riscv/starfive.yaml | 30 +++++++++++++++++++
> > 1 file changed, 30 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/riscv/starfive.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml
> > new file mode 100644
> > index 000000000000..4deae9f5c60d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml
> > @@ -0,0 +1,30 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/riscv/starfive.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: StarFive SoC-based boards
> > +
> > +maintainers:
> > + - Michael Zhu <michael.zhu@starfivetech.com>
> > + - Drew Fustini <drew@beagleboard.org>
> > +
> > +description:
> > + SiFive SoC-based boards
> > +
> > +properties:
> > + $nodename:
> > + const: '/'
> > + compatible:
> > + oneOf:
> > + - items:
> > + - const: beagle,beaglev-starlight-jh7100
> > + - const: starfive,jh7100
> > +
> > + - items:
> > + - const: starfive,jh7100
>
> This alone shouldn't be valid.
Thank you for pointing this out. I have removed that const item and the
dtbs_check still completes ok. I will send a v2.
Drew
prev parent reply other threads:[~2021-06-25 6:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 20:27 [PATCH] dt-bindings: riscv: add starfive jh7100 compatibles Drew Fustini
2021-06-24 21:20 ` Rob Herring
2021-06-25 6:59 ` Drew Fustini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210625065928.GA567037@x1 \
--to=drew@beagleboard.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=kernel@esmil.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=michael.zhu@starfivetech.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=tekkamanninja@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).