From: Huang Ying <ying.huang@intel.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
"Huang, Ying" <ying.huang@intel.com>,
Yang Shi <shy828301@gmail.com>, Greg Thelen <gthelen@google.com>,
Michal Hocko <mhocko@suse.com>, Wei Xu <weixugc@google.com>,
osalvador <osalvador@suse.de>, Zi Yan <ziy@nvidia.com>,
David Rientjes <rientjes@google.com>,
Dan Williams <dan.j.williams@intel.com>,
David Hildenbrand <david@redhat.com>
Subject: [PATCH -V9 6/9] mm/vmscan: add helper for querying ability to age anonymous pages
Date: Fri, 25 Jun 2021 15:32:01 +0800 [thread overview]
Message-ID: <20210625073204.1005986-7-ying.huang@intel.com> (raw)
In-Reply-To: <20210625073204.1005986-1-ying.huang@intel.com>
From: Dave Hansen <dave.hansen@linux.intel.com>
Anonymous pages are kept on their own LRU(s). These lists could
theoretically always be scanned and maintained. But, without swap,
there is currently nothing the kernel can *do* with the results of a
scanned, sorted LRU for anonymous pages.
A check for '!total_swap_pages' currently serves as a valid check as
to whether anonymous LRUs should be maintained. However, another
method will be added shortly: page demotion.
Abstract out the 'total_swap_pages' checks into a helper, give it a
logically significant name, and check for the possibility of page
demotion.
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
Reviewed-by: Yang Shi <shy828301@gmail.com>
Reviewed-by: Greg Thelen <gthelen@google.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Wei Xu <weixugc@google.com>
Cc: osalvador <osalvador@suse.de>
Cc: Zi Yan <ziy@nvidia.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: David Hildenbrand <david@redhat.com>
Changes since 20210618:
* Rename function per Oscar's comments.
* Change parameter per Wei's comments.
* Make the function static.
* Consider whether demotion is disabled.
---
mm/vmscan.c | 25 +++++++++++++++++++++++--
1 file changed, 23 insertions(+), 2 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 78b3bae71520..55f6192b2a51 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2716,6 +2716,26 @@ static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc,
}
}
+/*
+ * Anonymous LRU management is a waste if there is
+ * ultimately no way to reclaim the memory.
+ */
+static bool anon_can_be_aged(struct pglist_data *pgdat,
+ struct scan_control *sc)
+{
+ /* Aging the anon LRU is valuable if swap is present: */
+ if (total_swap_pages > 0)
+ return true;
+
+ /* Also valuable if anon pages can be demoted: */
+ if (!sc->no_demotion &&
+ next_demotion_node(pgdat->node_id) != NUMA_NO_NODE)
+ return true;
+
+ /* No way to reclaim anon pages. Should not age anon LRUs: */
+ return false;
+}
+
static void shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc)
{
unsigned long nr[NR_LRU_LISTS];
@@ -2825,7 +2845,8 @@ static void shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc)
* Even if we did not try to evict anon pages at all, we want to
* rebalance the anon lru active/inactive ratio.
*/
- if (total_swap_pages && inactive_is_low(lruvec, LRU_INACTIVE_ANON))
+ if (anon_can_be_aged(lruvec_pgdat(lruvec), sc) &&
+ inactive_is_low(lruvec, LRU_INACTIVE_ANON))
shrink_active_list(SWAP_CLUSTER_MAX, lruvec,
sc, LRU_ACTIVE_ANON);
}
@@ -3654,7 +3675,7 @@ static void age_active_anon(struct pglist_data *pgdat,
struct mem_cgroup *memcg;
struct lruvec *lruvec;
- if (!total_swap_pages)
+ if (!anon_can_be_aged(pgdat, sc))
return;
lruvec = mem_cgroup_lruvec(NULL, pgdat);
--
2.30.2
next prev parent reply other threads:[~2021-06-25 7:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 7:31 [PATCH -V9 0/9] Migrate Pages in lieu of discard Huang Ying
2021-06-25 7:31 ` [PATCH -V9 1/9] mm/numa: add node demotion data structure Huang Ying
2021-06-25 7:31 ` [PATCH -V9 2/9] mm/migrate: update node demotion order during on hotplug events Huang Ying
2021-06-25 21:26 ` Dave Hansen
2021-06-25 7:31 ` [PATCH -V9 3/9] mm/migrate: enable returning precise migrate_pages() success count Huang Ying
2021-06-25 7:31 ` [PATCH -V9 4/9] mm/migrate: demote pages during reclaim Huang Ying
2021-06-26 0:21 ` Wei Xu
2021-06-28 1:52 ` Huang, Ying
2021-06-25 7:32 ` [PATCH -V9 5/9] mm/vmscan: add page demotion counter Huang Ying
2021-06-25 7:32 ` Huang Ying [this message]
2021-06-25 7:32 ` [PATCH -V9 7/9] mm/vmscan: Consider anonymous pages without swap Huang Ying
2021-06-26 0:02 ` Wei Xu
2021-06-28 2:56 ` Huang, Ying
2021-06-25 7:32 ` [PATCH -V9 8/9] mm/vmscan: never demote for memcg reclaim Huang Ying
2021-06-25 7:32 ` [PATCH -V9 9/9] mm/migrate: add sysfs interface to enable reclaim migration Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210625073204.1005986-7-ying.huang@intel.com \
--to=ying.huang@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=gthelen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=rientjes@google.com \
--cc=shy828301@gmail.com \
--cc=weixugc@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).