linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] ARM: dts: fp5280g2: Add KCS node for LPC MCTP
@ 2021-06-25  7:40 George Liu
  2021-07-01  4:06 ` Andrew Jeffery
  0 siblings, 1 reply; 2+ messages in thread
From: George Liu @ 2021-06-25  7:40 UTC (permalink / raw)
  To: linux-aspeed
  Cc: devicetree, openbmc, linux-kernel, robh+dt, linux-arm-kernel,
	joel, George Liu

Signed-off-by: George Liu <liuxiwei@inspur.com>
---
 arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
index 1752f3250e44..66c0542b2694 100644
--- a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
@@ -300,6 +300,11 @@ &lpc_ctrl {
 	flash = <&spi1>;
 };
 
+&kcs4 {
+	compatible = "openbmc,mctp-lpc";
+	status = "okay";
+};
+
 &mac0 {
 	status = "okay";
 	pinctrl-names = "default";
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] ARM: dts: fp5280g2: Add KCS node for LPC MCTP
  2021-06-25  7:40 [PATCH v1] ARM: dts: fp5280g2: Add KCS node for LPC MCTP George Liu
@ 2021-07-01  4:06 ` Andrew Jeffery
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Jeffery @ 2021-07-01  4:06 UTC (permalink / raw)
  To: George Liu, linux-aspeed
  Cc: devicetree, openbmc, linux-kernel, Rob Herring, George Liu,
	linux-arm-kernel

Hi George,

On Fri, 25 Jun 2021, at 17:10, George Liu wrote:
> Signed-off-by: George Liu <liuxiwei@inspur.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts 
> b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> index 1752f3250e44..66c0542b2694 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> @@ -300,6 +300,11 @@ &lpc_ctrl {
>  	flash = <&spi1>;
>  };
>  
> +&kcs4 {
> +	compatible = "openbmc,mctp-lpc";
> +	status = "okay";
> +};

This was a gross hack that we carried for a bit, it never went or was 
intended to go upstream. Please just use the standard KCS bindings.

Cheers,

Andrew

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-01  4:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-25  7:40 [PATCH v1] ARM: dts: fp5280g2: Add KCS node for LPC MCTP George Liu
2021-07-01  4:06 ` Andrew Jeffery

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).