From: "Pali Rohár" <pali@kernel.org> To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Bjorn Helgaas <bhelgaas@google.com>, Rob Herring <robh@kernel.org> Cc: "Marek Behún" <kabel@kernel.org>, "Marc Zyngier" <maz@kernel.org>, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/7] PCI: aardvark: Don't mask irq when mapping Date: Fri, 25 Jun 2021 11:03:16 +0200 [thread overview] Message-ID: <20210625090319.10220-5-pali@kernel.org> (raw) In-Reply-To: <20210625090319.10220-1-pali@kernel.org> By default, all Legacy INTx interrupts are masked, so there is no need to mask this interrupt during irq_map callback. Signed-off-by: Pali Rohár <pali@kernel.org> Reviewed-by: Marek Behún <kabel@kernel.org> --- drivers/pci/controller/pci-aardvark.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c index bf44d6bfd0ca..c4fa64a31733 100644 --- a/drivers/pci/controller/pci-aardvark.c +++ b/drivers/pci/controller/pci-aardvark.c @@ -1060,7 +1060,6 @@ static int advk_pcie_irq_map(struct irq_domain *h, { struct advk_pcie *pcie = h->host_data; - advk_pcie_irq_mask(irq_get_irq_data(virq)); irq_set_status_flags(virq, IRQ_LEVEL); irq_set_chip_and_handler(virq, &pcie->irq_chip, handle_level_irq); -- 2.20.1
next prev parent reply other threads:[~2021-06-25 9:05 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-25 9:03 [PATCH 0/7] PCI: aardvark: Interrupt fixes Pali Rohár 2021-06-25 9:03 ` [PATCH 1/7] PCI: aardvark: Do not touch status bits of masked interrupts in interrupt handler Pali Rohár 2021-06-25 9:03 ` [PATCH 2/7] PCI: aardvark: Check for virq mapping when processing INTx IRQ Pali Rohár 2021-08-06 8:29 ` Marc Zyngier 2021-08-23 16:33 ` Pali Rohár 2021-08-23 16:47 ` Marc Zyngier 2021-06-25 9:03 ` [PATCH 3/7] PCI: aardvark: Remove irq_mask_ack callback for INTx interrupts Pali Rohár 2021-06-25 9:03 ` Pali Rohár [this message] 2021-06-25 9:03 ` [PATCH 5/7] PCI: aardvark: Fix support for MSI interrupts Pali Rohár 2021-06-25 9:03 ` [PATCH 6/7] PCI: aardvark: Correctly clear and unmask all " Pali Rohár 2021-08-06 8:32 ` Marc Zyngier 2021-08-06 8:35 ` Pali Rohár 2021-08-23 16:42 ` Pali Rohár 2021-06-25 9:03 ` [PATCH 7/7] PCI: aardvark: Fix setting MSI address Pali Rohár 2021-08-05 17:35 ` [PATCH 0/7] PCI: aardvark: Interrupt fixes Pali Rohár
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210625090319.10220-5-pali@kernel.org \ --to=pali@kernel.org \ --cc=bhelgaas@google.com \ --cc=kabel@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=maz@kernel.org \ --cc=robh@kernel.org \ --cc=thomas.petazzoni@bootlin.com \ --subject='Re: [PATCH 4/7] PCI: aardvark: Don'\''t mask irq when mapping' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).