From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84B5BC49EA6 for ; Sat, 26 Jun 2021 08:57:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63E0761920 for ; Sat, 26 Jun 2021 08:57:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229873AbhFZI70 (ORCPT ); Sat, 26 Jun 2021 04:59:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:40642 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbhFZI7Z (ORCPT ); Sat, 26 Jun 2021 04:59:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 94AF661920; Sat, 26 Jun 2021 08:56:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624697823; bh=qmG1JfvdGzsA0YlwqYbabUV+AHbdvuyoe9DUjculXA8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZMUoH0PVIaYf1Uix6rrjUT5KrcQKsvOWAgPMXRrykwR0NU+uTmfW6bZRysxzxn8P0 OiBKET2vFg0BZ2lqa9qIW15uFYVQY7mVULDZDAG6GAjLAjjoxzVlHQHhJqPrFkrEhy npHIeNS17+gXb4XfgioqT8jv9DcrcgRaKRrJd7bVMzkqSq1a0GeiI5Fxa+QRD/dnnx +CIpI1Qj7+TtWOoVUuaSIVe6OHGrAtrCYgM+jMqMuJKflN1vx4cWH6bGQY2ZSFyyl/ GgJEb8RDnTFOPnkTGJWC+k3LIts337H4K72bdNPjNcb1nAuHeqfccqy0PD+cMV1LHZ +yQJ3gato9zCw== Date: Sat, 26 Jun 2021 16:56:55 +0800 From: Peter Chen To: Pawel Laszczak Cc: rogerq@kernel.org, a-govindraju@ti.com, gregkh@linuxfoundation.org, felipe.balbi@linux.intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, kurahul@cadence.com, sparmar@cadence.com, stable@vger.kernel.org Subject: Re: [PATCH] usb: cdns3: Fixed incorrect gadget state Message-ID: <20210626085655.GA13671@Peter> References: <20210623070247.46151-1-pawell@gli-login.cadence.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210623070247.46151-1-pawell@gli-login.cadence.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21-06-23 09:02:47, Pawel Laszczak wrote: > From: Pawel Laszczak > > For delayed status phase, the usb_gadget->state was set > to USB_STATE_ADDRESS and it has never been updated to > USB_STATE_CONFIGURED. > Patch updates the gadget state to correct USB_STATE_CONFIGURED. > As a result of this bug the controller was not able to enter to > Test Mode while using MSC function. Pawel, would you please describe more about this issue? I remember the cdns3 controller at i.mx series SoC could enter test mode by using current code. Peter > > Cc: > Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver") > Signed-off-by: Pawel Laszczak > --- > drivers/usb/cdns3/cdns3-ep0.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/cdns3/cdns3-ep0.c b/drivers/usb/cdns3/cdns3-ep0.c > index 9a17802275d5..ec5bfd8944c3 100644 > --- a/drivers/usb/cdns3/cdns3-ep0.c > +++ b/drivers/usb/cdns3/cdns3-ep0.c > @@ -731,6 +731,7 @@ static int cdns3_gadget_ep0_queue(struct usb_ep *ep, > request->actual = 0; > priv_dev->status_completion_no_call = true; > priv_dev->pending_status_request = request; > + usb_gadget_set_state(&priv_dev->gadget, USB_STATE_CONFIGURED); > spin_unlock_irqrestore(&priv_dev->lock, flags); > > /* > -- > 2.25.1 > -- Thanks, Peter Chen