From: kernel test robot <lkp@intel.com>
To: Mike Tipton <mdtipton@codeaurora.org>, djakov@kernel.org
Cc: kbuild-all@lists.01.org, bjorn.andersson@linaro.org,
agross@kernel.org, saravanak@google.com, okukatla@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mike Tipton <mdtipton@codeaurora.org>
Subject: Re: [PATCH 3/4] interconnect: qcom: icc-rpmh: Ensure floor BW is enforced for all nodes
Date: Sat, 26 Jun 2021 10:27:55 +0800 [thread overview]
Message-ID: <202106261031.qETVG77h-lkp@intel.com> (raw)
In-Reply-To: <20210625212839.24155-4-mdtipton@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 3740 bytes --]
Hi Mike,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.13-rc7 next-20210625]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mike-Tipton/interconnect-Fix-sync-state-issues/20210626-053132
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 55fcd4493da5ac8a0f7a0b3b5ae8448aee2041bb
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/ad01b68a345bdae6c24bd45720f4a01a2f9be49b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mike-Tipton/interconnect-Fix-sync-state-issues/20210626-053132
git checkout ad01b68a345bdae6c24bd45720f4a01a2f9be49b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/interconnect/qcom/icc-rpmh.c: In function 'qcom_icc_set':
>> drivers/interconnect/qcom/icc-rpmh.c:87:24: warning: variable 'qn' set but not used [-Wunused-but-set-variable]
87 | struct qcom_icc_node *qn;
| ^~
vim +/qn +87 drivers/interconnect/qcom/icc-rpmh.c
976daac4a1c581 David Dai 2020-02-28 76
976daac4a1c581 David Dai 2020-02-28 77 /**
976daac4a1c581 David Dai 2020-02-28 78 * qcom_icc_set - set the constraints based on path
976daac4a1c581 David Dai 2020-02-28 79 * @src: source node for the path to set constraints on
976daac4a1c581 David Dai 2020-02-28 80 * @dst: destination node for the path to set constraints on
976daac4a1c581 David Dai 2020-02-28 81 *
976daac4a1c581 David Dai 2020-02-28 82 * Return: 0 on success, or an error code otherwise
976daac4a1c581 David Dai 2020-02-28 83 */
976daac4a1c581 David Dai 2020-02-28 84 int qcom_icc_set(struct icc_node *src, struct icc_node *dst)
976daac4a1c581 David Dai 2020-02-28 85 {
976daac4a1c581 David Dai 2020-02-28 86 struct qcom_icc_provider *qp;
266cd33b591385 Georgi Djakov 2020-10-22 @87 struct qcom_icc_node *qn;
976daac4a1c581 David Dai 2020-02-28 88 struct icc_node *node;
976daac4a1c581 David Dai 2020-02-28 89
976daac4a1c581 David Dai 2020-02-28 90 if (!src)
976daac4a1c581 David Dai 2020-02-28 91 node = dst;
976daac4a1c581 David Dai 2020-02-28 92 else
976daac4a1c581 David Dai 2020-02-28 93 node = src;
976daac4a1c581 David Dai 2020-02-28 94
976daac4a1c581 David Dai 2020-02-28 95 qp = to_qcom_provider(node->provider);
266cd33b591385 Georgi Djakov 2020-10-22 96 qn = node->data;
266cd33b591385 Georgi Djakov 2020-10-22 97
976daac4a1c581 David Dai 2020-02-28 98 qcom_icc_bcm_voter_commit(qp->voter);
976daac4a1c581 David Dai 2020-02-28 99
976daac4a1c581 David Dai 2020-02-28 100 return 0;
976daac4a1c581 David Dai 2020-02-28 101 }
976daac4a1c581 David Dai 2020-02-28 102 EXPORT_SYMBOL_GPL(qcom_icc_set);
976daac4a1c581 David Dai 2020-02-28 103
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 77613 bytes --]
next prev parent reply other threads:[~2021-06-26 2:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 21:28 [PATCH 0/4] interconnect: Fix sync-state issues Mike Tipton
2021-06-25 21:28 ` [PATCH 1/4] interconnect: Zero initial BW after sync-state Mike Tipton
2021-07-01 16:56 ` okukatla
2021-07-12 15:41 ` Mike Tipton
2021-06-25 21:28 ` [PATCH 2/4] interconnect: Always call pre_aggregate before aggregate Mike Tipton
2021-07-01 18:55 ` okukatla
2021-07-12 15:39 ` Mike Tipton
2021-06-25 21:28 ` [PATCH 3/4] interconnect: qcom: icc-rpmh: Ensure floor BW is enforced for all nodes Mike Tipton
2021-06-26 2:27 ` kernel test robot [this message]
2021-07-01 18:48 ` okukatla
2021-07-12 15:45 ` Mike Tipton
2021-06-25 21:28 ` [PATCH 4/4] interconnect: qcom: icc-rpmh: Add BCMs to commit list in pre_aggregate Mike Tipton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202106261031.qETVG77h-lkp@intel.com \
--to=lkp@intel.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=djakov@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mdtipton@codeaurora.org \
--cc=okukatla@codeaurora.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).