From: Lukasz Majewski <lukma@denx.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Madalin Bucur <madalin.bucur@oss.nxp.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
netdev@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Mark Einon <mark.einon@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 2/3] net: Provide switchdev driver for NXP's More Than IP L2 switch
Date: Mon, 28 Jun 2021 14:05:26 +0200 [thread overview]
Message-ID: <20210628140526.7417fbf2@ktm> (raw)
In-Reply-To: <YNXq1bp7XH8jRyx0@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 1921 bytes --]
Hi Andrew,
> > I do believe that I can just extend the L2 switch driver (fec_mtip.c
> > file to be precise) to provide full blown L2 switch functionality
> > without touching the legacy FEC more than in this patch set.
> >
> > Would you consider applying this patch series then?
>
> What is most important is the ABI. If something is merged now, we need
> to ensure it does not block later refactoring to a clean new
> driver. The DT binding is considered ABI. So the DT binding needs to
> be like a traditional switchdev driver. Florian already pointed out,
> you can use a binding very similar to DSA. ti,cpsw-switch.yaml is
> another good example.
The best I could get would be:
ð_switch {
compatible = "imx,mtip-l2switch";
reg = <0x800f8000 0x400>, <0x800fC000 0x4000>;
interrupts = <100>;
status = "okay";
ethernet-ports {
port1@1 {
reg = <1>;
label = "eth0";
phys = <&mac0 0>;
};
port2@2 {
reg = <2>;
label = "eth1";
phys = <&mac1 1>;
};
};
};
Which would abuse the "phys" properties usages - as 'mac[01]' are
referring to ethernet controllers.
On TI SoCs (e.g. am33xx-l4.dtsi) phys refer to some separate driver
responsible for PHY management. On NXP this is integrated with FEC
driver itself.
>
> So before considering merging your changes, i would like to see a
> usable binding.
>
> I also don't remember seeing support for STP. Without that, your
> network has broadcast storm problems when there are loops. So i would
> like to see the code needed to put ports into blocking, listening,
> learning, and forwarding states.
>
> Andrew
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-06-28 12:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210622144111.19647-1-lukma@denx.de>
[not found] ` <20210622144111.19647-2-lukma@denx.de>
[not found] ` <YNH3mb9fyBjLf0fj@lunn.ch>
2021-06-22 20:51 ` [RFC 1/3] ARM: dts: imx28: Add description for L2 switch on XEA board Lukasz Majewski
2021-06-23 13:17 ` Andrew Lunn
2021-06-23 15:26 ` Lukasz Majewski
2021-06-24 0:36 ` Florian Fainelli
2021-06-24 2:19 ` Joakim Zhang
2021-06-24 11:21 ` Lukasz Majewski
2021-06-25 8:28 ` Joakim Zhang
2021-06-25 10:18 ` Lukasz Majewski
2021-06-24 11:03 ` Lukasz Majewski
[not found] ` <20210622144111.19647-4-lukma@denx.de>
[not found] ` <YNH9YvjqbcHMaUFw@lunn.ch>
2021-06-23 7:48 ` [RFC 3/3] net: imx: Adjust fec_main.c to provide support for L2 switch Lukasz Majewski
[not found] ` <20210622144111.19647-3-lukma@denx.de>
[not found] ` <YNH7vS9FgvEhz2fZ@lunn.ch>
[not found] ` <20210623133704.334a84df@ktm>
[not found] ` <YNOTKl7ZKk8vhcMR@lunn.ch>
2021-06-24 10:53 ` [RFC 2/3] net: Provide switchdev driver for NXP's More Than IP " Lukasz Majewski
2021-06-24 13:34 ` Andrew Lunn
2021-06-24 14:35 ` Lukasz Majewski
2021-06-24 16:11 ` Andrew Lunn
2021-06-25 9:59 ` Lukasz Majewski
2021-06-25 14:40 ` Andrew Lunn
2021-06-28 12:05 ` Lukasz Majewski [this message]
2021-06-28 12:48 ` Vladimir Oltean
2021-06-28 14:13 ` Lukasz Majewski
2021-06-28 14:23 ` Vladimir Oltean
2021-06-29 8:09 ` Lukasz Majewski
2021-06-29 9:30 ` Vladimir Oltean
2021-06-29 12:01 ` Lukasz Majewski
2021-06-28 13:23 ` Andrew Lunn
2021-06-28 14:14 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210628140526.7417fbf2@ktm \
--to=lukma@denx.de \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@oss.nxp.com \
--cc=mark.einon@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=olteanv@gmail.com \
--cc=qiangqing.zhang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).