From: "Paul A. Clarke" <pc@us.ibm.com>
To: kajoljain <kjain@linux.ibm.com>
Cc: ravi.bangoria@linux.ibm.com, atrajeev@linux.vnet.ibm.com,
rnsastry@linux.ibm.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, acme@kernel.org,
linux-perf-users@vger.kernel.org, maddy@linux.vnet.ibm.com,
jolsa@redhat.com
Subject: Re: [PATCH] perf vendor events power10: Adds 24x7 nest metric events for power10 platform
Date: Mon, 28 Jun 2021 09:30:07 -0500 [thread overview]
Message-ID: <20210628143007.GD142768@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> (raw)
In-Reply-To: <d2eaebb6-7cd6-d2e3-0bed-0c054e7d2207@linux.ibm.com>
On Mon, Jun 28, 2021 at 11:58:54AM +0530, kajoljain wrote:
>
>
> On 6/25/21 6:51 PM, Paul A. Clarke wrote:
> > On Fri, Jun 25, 2021 at 05:29:48PM +0530, Kajol Jain wrote:
> >> Patch adds 24x7 nest metric events for POWER10.
> >>
> >> Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
> >> ---
> >> .../arch/powerpc/power10/nest_metrics.json | 491 ++++++++++++++++++
> >> 1 file changed, 491 insertions(+)
> >> create mode 100644 tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json
> >>
> >> diff --git a/tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json b/tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json
> >> new file mode 100644
> >> index 000000000000..b79046cd8b09
> >> --- /dev/null
> >> +++ b/tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json
> >> @@ -0,0 +1,491 @@
> >> +[
> >> + {
> >> + "MetricName": "VEC_GROUP_PUMP_RETRY_RATIO_P01",
> >> + "BriefDescription": "VEC_GROUP_PUMP_RETRY_RATIO_P01",
> >
> > Is it possible to get better descriptions than just a restatement of the
> > name, or no description at all?
> >
> > This comment obviously applies to almost all of the metrics herein.
>
> Hi Paul,
> Thanks for reviewing the patch. Sure I will remove description part for now.
My sentence didn't parse well, sorry...
What I really meant was more like "Is it possible to get better descriptions?
Having just a restatement of the name (or no description at all in some cases)
is not helpful."
So, can we provide better descriptions of the metrics?
PC
next prev parent reply other threads:[~2021-06-28 14:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 11:59 [PATCH] perf vendor events power10: Adds 24x7 nest metric events for power10 platform Kajol Jain
2021-06-25 13:21 ` Paul A. Clarke
2021-06-28 6:28 ` kajoljain
2021-06-28 14:30 ` Paul A. Clarke [this message]
2021-06-25 15:42 ` Nageswara Sastry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210628143007.GD142768@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com \
--to=pc@us.ibm.com \
--cc=acme@kernel.org \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=jolsa@redhat.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=ravi.bangoria@linux.ibm.com \
--cc=rnsastry@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).