From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Sibi S <sibis@codeaurora.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: soc: qcom: aoss: Convert to YAML
Date: Mon, 28 Jun 2021 20:19:08 +0530 [thread overview]
Message-ID: <20210628144908.GC4033@workstation> (raw)
In-Reply-To: <20210625234018.1324681-3-bjorn.andersson@linaro.org>
On Fri, Jun 25, 2021 at 04:40:17PM -0700, Bjorn Andersson wrote:
> Convert to YAML in order to allow validation.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> I'm aware that this conflicts with Sibi's removal of '#power-domain-cells', but
> that's a trivial change regardless of which of the two patches gets in first.
>
> .../bindings/soc/qcom/qcom,aoss-qmp.txt | 90 --------------
> .../bindings/soc/qcom/qcom,aoss-qmp.yaml | 115 ++++++++++++++++++
> 2 files changed, 115 insertions(+), 90 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml
>
[...]
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - mboxes
> + - "#clock-cells"
The old binding lists this property as optional but you're marking it
as required. And by looking at the driver it seems to be optional only.
> + - "#power-domain-cells"
This one was marked optional as well but the driver registers the pd's
unconditionally, so I guess it is fine.
Thanks,
Mani
> +
> +additionalProperties: false
> +
> +patternProperties:
> + "^(cx|mx|ebi)$":
> + type: object
> + description:
> + The AOSS side channel also provides the controls for three cooling devices,
> + these are expressed as subnodes of the QMP node. The name of the node is
> + used to identify the resource and must therefor be "cx", "mx" or "ebi".
> +
> + properties:
> + "#cooling-cells":
> + const: 2
> +
> + required:
> + - "#cooling-cells"
> +
> + additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + aoss_qmp: qmp@c300000 {
> + compatible = "qcom,sdm845-aoss-qmp", "qcom,aoss-qmp";
> + reg = <0x0c300000 0x100000>;
> + interrupts = <GIC_SPI 389 IRQ_TYPE_EDGE_RISING>;
> + mboxes = <&apss_shared 0>;
> +
> + #clock-cells = <0>;
> + #power-domain-cells = <1>;
> +
> + cx_cdev: cx {
> + #cooling-cells = <2>;
> + };
> +
> + mx_cdev: mx {
> + #cooling-cells = <2>;
> + };
> + };
> +...
> --
> 2.29.2
>
next prev parent reply other threads:[~2021-06-28 15:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 23:40 [PATCH 0/3] dt-bindings: soc: qcom: aoss: Support sc8180x and convert to YAML Bjorn Andersson
2021-06-25 23:40 ` [PATCH 1/3] dt-bindings: soc: qcom: aoss: Add SC8180X compatible Bjorn Andersson
2021-07-01 19:03 ` Rob Herring
2021-07-01 19:34 ` Bjorn Andersson
2021-06-25 23:40 ` [PATCH 2/3] dt-bindings: soc: qcom: aoss: Convert to YAML Bjorn Andersson
2021-06-28 14:49 ` Manivannan Sadhasivam [this message]
2021-06-28 16:09 ` Bjorn Andersson
2021-07-01 14:02 ` Rob Herring
2021-07-01 19:03 ` Rob Herring
2021-07-09 17:27 ` Bjorn Andersson
2021-07-12 19:29 ` Rob Herring
2021-06-25 23:40 ` [PATCH 3/3] soc: qcom: aoss: Add generic compatible Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210628144908.GC4033@workstation \
--to=manivannan.sadhasivam@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).