archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <>
To: Alexandru Ardelean <>
	Dmitry Torokhov <>,
	Guenter Roeck <>
Subject: Re: [RFC PATCH] regulator: devres: disable regulator on release if refcount is 1
Date: Mon, 28 Jun 2021 15:53:07 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

On Fri, Jun 25, 2021 at 03:53:07PM +0300, Alexandru Ardelean wrote:

> This means that the last 'regulator_disable()' (on driver remove) becomes
> optional.
> If there are any unbalanced regulator_enable()/regulator_disable() calls,
> the 'enable_count' won't be touched and 'regulator_put()' will print a
> warning.

This doesn't seem like it's going to make reviewing and debugging
reference counting issues any easier, it seems even more of a concern
than a devm version TBH.  It's also not clear why if we were doing this
we'd restrict it to a single reference.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-06-28 15:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25 12:53 Alexandru Ardelean
2021-06-28 14:53 ` Mark Brown [this message]
2021-06-29  7:55   ` Alexandru Ardelean
2021-06-30 12:49 ` [RFC PATCH v2] regulator: devres: add devm_regulator_enable() as short-hand Alexandru Ardelean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [RFC PATCH] regulator: devres: disable regulator on release if refcount is 1' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).