archive mirror
 help / color / mirror / Atom feed
From: "Marek Behún" <>
To: "Pali Rohár" <>
Cc: Andrew Lunn <>,
	Gregory Clement <>,
	Sebastian Hesselbarth <>,
	Rob Herring <>,
	Russell King <>,,,
Subject: Re: [PATCH] arm64: dts: armada-3720-turris-mox.dts: remove mrvl,i2c-fast-mode
Date: Mon, 28 Jun 2021 15:05:53 +0200	[thread overview]
Message-ID: <20210628150553.4e026d19@thinkpad> (raw)
In-Reply-To: <>

On Mon, 28 Jun 2021 14:10:15 +0200
Pali Rohár <> wrote:

> +	/delete-property/mrvl,i2c-fast-mode;

Can you add an additional space here?
  /delete-property/ mrvl,i2c-fast-mode;

Other than that

Reviewed-by: Marek Behún <>

BTW the i2c driver should me made to respect the `clock-frequency` DT
property, not the fast-mode nonsense.

The `mrvl,i2c-fast-mode` should be IMO completely removed and whether it
is enabled should be decided by the value of `clock-frequency`.

BTW there are clock generating registers in A3720 I2C controller that
can generate 100 kHz even in fast-mode. The driver does not use them,
though, it leaves them to their default values, which for normal mode
generate ~96 kHz and for fast mode ~258 kHz. Maybe we should implement
configuring these registers and make the driver choose
normal-mode / fast-mode / high-speed mode depending on
`clock-frequency` ?


  reply	other threads:[~2021-06-28 13:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28 12:10 Pali Rohár
2021-06-28 13:05 ` Marek Behún [this message]
2021-06-28 13:10 ` Marek Behún
2021-06-28 15:12 ` [PATCH v2] arm64: dts: armada-3720-turris-mox: " Pali Rohár
2021-06-28 16:16   ` Russell King (Oracle)
2021-07-23 12:56   ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210628150553.4e026d19@thinkpad \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] arm64: dts: armada-3720-turris-mox.dts: remove mrvl,i2c-fast-mode' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).