From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 769E2C11F66 for ; Tue, 29 Jun 2021 01:05:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 565B261409 for ; Tue, 29 Jun 2021 01:05:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232018AbhF2BIJ (ORCPT ); Mon, 28 Jun 2021 21:08:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:37486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231970AbhF2BIH (ORCPT ); Mon, 28 Jun 2021 21:08:07 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 144056128A; Tue, 29 Jun 2021 01:05:39 +0000 (UTC) Date: Mon, 28 Jun 2021 21:05:38 -0400 From: Steven Rostedt To: Kefeng Wang Cc: Arnd Bergmann , , , Ingo Molnar , "David S. Miller" Subject: Re: [PATCH 3/9] sections: Move and rename core_kernel_data() to is_kernel_data() Message-ID: <20210628210538.0fdded1c@oasis.local.home> In-Reply-To: <20210626073439.150586-4-wangkefeng.wang@huawei.com> References: <20210626073439.150586-1-wangkefeng.wang@huawei.com> <20210626073439.150586-4-wangkefeng.wang@huawei.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 26 Jun 2021 15:34:33 +0800 Kefeng Wang wrote: > Move core_kernel_data() into sections.h and rename it to > is_kernel_data(), also make it return bool value, then > update all the callers. Removing the "core" part of "core_kernel_data()" is misleading. As modules can have kernel data, but this will return false on module data (as it should). This is similar to core_kernel_text() which this series doesn't seem to touch. I'd like to keep the "core" in the name which makes it obvious this is not about module data, and if someone were to make it about module data, it will break ftrace synchronization. -- Steve