From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
kernel test robot <lkp@intel.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>
Subject: [for-next][PATCH 4/6] trace/osnoise: Fix return value on osnoise_init_hotplug_support
Date: Tue, 29 Jun 2021 07:48:15 -0400 [thread overview]
Message-ID: <20210629114851.531030823@goodmis.org> (raw)
In-Reply-To: 20210629114811.473560262@goodmis.org
From: Daniel Bristot de Oliveira <bristot@redhat.com>
kernel test robot reported:
>> kernel/trace/trace_osnoise.c:1584:2: error: void function
'osnoise_init_hotplug_support' should not return a
value [-Wreturn-type]
return 0;
When !CONFIG_HOTPLUG_CPU.
Fix it problem by removing the return value.
Link: https://lkml.kernel.org/r/c7fc67f1a117cc88bab2e508c898634872795341.1624872608.git.bristot@redhat.com
Fixes: c8895e271f79 ("trace/osnoise: Support hotplug operations")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Daniel Bristot de Oliveira <bristot@redhat.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
kernel/trace/trace_osnoise.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c
index 79be14380581..085a83de98ad 100644
--- a/kernel/trace/trace_osnoise.c
+++ b/kernel/trace/trace_osnoise.c
@@ -1586,7 +1586,7 @@ static void osnoise_init_hotplug_support(void)
#else /* CONFIG_HOTPLUG_CPU */
static void osnoise_init_hotplug_support(void)
{
- return 0;
+ return;
}
#endif /* CONFIG_HOTPLUG_CPU */
--
2.30.2
next prev parent reply other threads:[~2021-06-29 11:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 11:48 [for-next][PATCH 0/6] tracing: Minor fixes Steven Rostedt
2021-06-29 11:48 ` [for-next][PATCH 1/6] tracing: Have osnoise_main() add a quiescent state for task rcu Steven Rostedt
2021-06-29 11:48 ` [for-next][PATCH 2/6] trace/osnoise: Fix no previous prototype warnings Steven Rostedt
2021-06-29 11:48 ` [for-next][PATCH 3/6] trace/osnoise: Make interval u64 on osnoise_main Steven Rostedt
2021-06-29 11:48 ` Steven Rostedt [this message]
2021-06-29 11:48 ` [for-next][PATCH 5/6] Documentation: Fix a typo on trace/osnoise-tracer Steven Rostedt
2021-06-29 11:48 ` [for-next][PATCH 6/6] tracing: Fix spelling in osnoise tracer "interferences" -> "interference" Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210629114851.531030823@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=bristot@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).