From: "Paul E. McKenney" <paulmck@kernel.org>
To: liu.song11@zte.com.cn
Cc: fishland@aliyun.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: Remove unnecessary updates to ret in rcu_gp_fqs_loop
Date: Tue, 29 Jun 2021 21:23:14 -0700 [thread overview]
Message-ID: <20210630042314.GU4397@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <202106301122531910761@zte.com.cn>
On Wed, Jun 30, 2021 at 11:22:53AM +0800, liu.song11@zte.com.cn wrote:
> > rcu: Remove useless "ret" update in rcu_gp_fqs_loop()
> >
> > Within rcu_gp_fqs_loop(), the "ret" local variable is set to the
> > return value from swait_event_idle_timeout_exclusive(), but "ret" is
> > unconditionally overwritten later in the code. This commit therefore
> > removes this useless assignment.
>
> The revised commit log is exactly what I want to express, it is perfect.
Thank you for looking it over!
Thanx, Paul
prev parent reply other threads:[~2021-06-30 4:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210629135551.4080-1-fishland@aliyun.com>
2021-06-29 17:44 ` [PATCH] rcu: Remove unnecessary updates to ret in rcu_gp_fqs_loop Paul E. McKenney
[not found] ` <202106301122531910761@zte.com.cn>
2021-06-30 4:23 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210630042314.GU4397@paulmck-ThinkPad-P17-Gen-1 \
--to=paulmck@kernel.org \
--cc=fishland@aliyun.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liu.song11@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).