From: Steffen Klassert <steffen.klassert@secunet.com>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
<0x7f454c46@gmail.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-kernel-mentees@lists.linuxfoundation.org>,
<syzbot+fb347cf82c73a90efcca@syzkaller.appspotmail.com>
Subject: Re: [PATCH] net: xfrm: fix memory leak in xfrm_user_rcv_msg
Date: Wed, 30 Jun 2021 08:51:07 +0200 [thread overview]
Message-ID: <20210630065107.GT40979@gauss3.secunet.de> (raw)
In-Reply-To: <20210625102354.18266-1-paskripkin@gmail.com>
On Fri, Jun 25, 2021 at 01:23:54PM +0300, Pavel Skripkin wrote:
> Syzbot reported memory leak in xfrm_user_rcv_msg(). The
> problem was is non-freed skb's frag_list.
>
> In skb_release_all() skb_release_data() will be called only
> in case of skb->head != NULL, but netlink_skb_destructor()
> sets head to NULL. So, allocated frag_list skb should be
> freed manualy, since consume_skb() won't take care of it
>
> Fixes: 5106f4a8acff ("xfrm/compat: Add 32=>64-bit messages translator")
> Reported-and-tested-by: syzbot+fb347cf82c73a90efcca@syzkaller.appspotmail.com
> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Applied, thanks a lot!
prev parent reply other threads:[~2021-06-30 6:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 10:23 [PATCH] net: xfrm: fix memory leak in xfrm_user_rcv_msg Pavel Skripkin
2021-06-30 6:51 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210630065107.GT40979@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=0x7f454c46@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=syzbot+fb347cf82c73a90efcca@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).