Re: [RESEND PATCH v2 1/2] spi:amd: Add support for latest platform

From: kernel test robot <lkp@intel.com>
To: Nehal Bakulchandra Shah <Nehal-Bakulchandra.shah@amd.com>,
	broonie@kernel.org
Cc: kbuild-all@lists.01.org, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Nehal Bakulchandra Shah <Nehal-Bakulchandra.shah@amd.com>,
	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
	Liang Liang <liang.liang@amd.com>
Subject: Re: [RESEND PATCH v2 1/2] spi:amd: Add support for latest platform
Date: Wed, 30 Jun 2021 08:23:53 +0800	[thread overview]
Message-ID: <202106300802.L4KtEraV-lkp@intel.com> (raw)
In-Reply-To: <20210629163834.581774-2-Nehal-Bakulchandra.shah@amd.com>

[-- Attachment #1: Type: text/plain, Size: 2365 bytes --]

Hi Nehal,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on spi/for-next]
[also build test ERROR on v5.13 next-20210629]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nehal-Bakulchandra-Shah/spi-amd-Support-for-new-generation-of-AMD-SOCs/20210630-004001
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: nios2-randconfig-r035-20210628 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/dafe3f01e7cd854b133ee3feb6306e883d38fc15
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Nehal-Bakulchandra-Shah/spi-amd-Support-for-new-generation-of-AMD-SOCs/20210630-004001
        git checkout dafe3f01e7cd854b133ee3feb6306e883d38fc15
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/spi/spi-amd.c: In function 'amd_spi_set_opcode':
>> drivers/spi/spi-amd.c:141:28: error: dereferencing pointer to incomplete type 'const struct amd_spi_devtype_data'
     141 |  if (!amd_spi->devtype_data->version)
         |                            ^~

vim +141 drivers/spi/spi-amd.c

   136	
   137	static void amd_spi_set_opcode(struct spi_master *master, u8 cmd_opcode)
   138	{
   139		struct amd_spi *amd_spi = spi_master_get_devdata(master);
   140	
 > 141		if (!amd_spi->devtype_data->version)
   142			amd_spi_setclear_reg32(master, AMD_SPI_CTRL0_REG, cmd_opcode,
   143					       AMD_SPI_OPCODE_MASK);
   144		else
   145			amd_spi_writereg8(master, AMD_SPI_OPCODE_REG, cmd_opcode);
   146	}
   147	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 17327 bytes --]