From: gushengxian <gushengxian507419@gmail.com>
To: nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com, perex@perex.cz,
tiwai@suse.com
Cc: linux-kernel@vger.kernel.org, gushengxian <gushengxian@yulong.com>
Subject: [PATCH] ASoC: fsl_xcvr: Remove redundant dev_err()
Date: Wed, 30 Jun 2021 02:41:12 -0700 [thread overview]
Message-ID: <20210630094112.3582-1-gushengxian507419@gmail.com> (raw)
From: gushengxian <gushengxian@yulong.com>
The print function dev_err() is redundant because
platform_get_irq() already prints an error.
Signed-off-by: gushengxian <gushengxian@yulong.com>
---
sound/soc/fsl/fsl_xcvr.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/soc/fsl/fsl_xcvr.c b/sound/soc/fsl/fsl_xcvr.c
index fb7c29fc39d7..31c5ee641fe7 100644
--- a/sound/soc/fsl/fsl_xcvr.c
+++ b/sound/soc/fsl/fsl_xcvr.c
@@ -1189,10 +1189,8 @@ static int fsl_xcvr_probe(struct platform_device *pdev)
/* get IRQs */
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(dev, "no irq[0]: %d\n", irq);
+ if (irq < 0)
return irq;
- }
ret = devm_request_irq(dev, irq, irq0_isr, 0, pdev->name, xcvr);
if (ret) {
--
2.25.1
reply other threads:[~2021-06-30 9:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210630094112.3582-1-gushengxian507419@gmail.com \
--to=gushengxian507419@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=gushengxian@yulong.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).