linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 net] net: stmmac: Terminate FPE workqueue in suspend
@ 2021-06-30  9:59 mohammad.athari.ismail
  2021-07-01 21:00 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: mohammad.athari.ismail @ 2021-06-30  9:59 UTC (permalink / raw)
  To: Alexandre Torgue, Jose Abreu, David S . Miller, Jakub Kicinski,
	Giuseppe Cavallaro, Maxime Coquelin
  Cc: Ong Boon Leong, Voon Weifeng, Tan Tee Min, netdev, linux-kernel,
	mohammad.athari.ismail

From: Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>

Add stmmac_fpe_stop_wq() in stmmac_suspend() to terminate FPE workqueue
during suspend. So, in suspend mode, there will be no FPE workqueue
available. Without this fix, new additional FPE workqueue will be created
in every suspend->resume cycle.

Fixes: 5a5586112b92 ("net: stmmac: support FPE link partner hand-shaking procedure")
Signed-off-by: Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>
---
v2 changelog:
- Removed  stable@vger.kernel.org from email cc list.
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index c87202cbd3d6..796ad594543d 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -7170,6 +7170,7 @@ int stmmac_suspend(struct device *dev)
 				     priv->plat->rx_queues_to_use, false);
 
 		stmmac_fpe_handshake(priv, false);
+		stmmac_fpe_stop_wq(priv);
 	}
 
 	priv->speed = SPEED_UNKNOWN;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2 net] net: stmmac: Terminate FPE workqueue in suspend
  2021-06-30  9:59 [PATCH v2 net] net: stmmac: Terminate FPE workqueue in suspend mohammad.athari.ismail
@ 2021-07-01 21:00 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-07-01 21:00 UTC (permalink / raw)
  To: Ismail, Mohammad Athari
  Cc: alexandre.torgue, joabreu, davem, kuba, peppe.cavallaro,
	mcoquelin.stm32, boon.leong.ong, weifeng.voon, tee.min.tan,
	netdev, linux-kernel

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Wed, 30 Jun 2021 17:59:35 +0800 you wrote:
> From: Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>
> 
> Add stmmac_fpe_stop_wq() in stmmac_suspend() to terminate FPE workqueue
> during suspend. So, in suspend mode, there will be no FPE workqueue
> available. Without this fix, new additional FPE workqueue will be created
> in every suspend->resume cycle.
> 
> [...]

Here is the summary with links:
  - [v2,net] net: stmmac: Terminate FPE workqueue in suspend
    https://git.kernel.org/netdev/net/c/6b28a86d6c0b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-01 21:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-30  9:59 [PATCH v2 net] net: stmmac: Terminate FPE workqueue in suspend mohammad.athari.ismail
2021-07-01 21:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).